Re: [Monotone-devel] [PATCH] fix use of hostname from parsed uri

[Zack Weinberg]

On Fri, Sep 26, 2008 at 5:59 PM, Roland McGrath <address@hidden> wrote:
>> > The test is any push/pull/sync operation using "mtn://server" instead of
>> > "server" (or "mtn://server:port/" instead of "server:port") as the ADDRESS
>> > parameter.
>>
>> I understood this; I was asking you to write an automated test that
>> could be added to the test suite, to ensure that it doesn't get broken
>> in the future.
>
> I understood this.  I was hoping that among experienced monotone hackers
> there might be some sympathy for the guy who sent in the fix, and someone
> might take the minute it took to commit the fix and throw in the five more
> minutes someone well-versed in the monotone tree would need to add the
> simple test case.  But thanks for the invitation to spend all day trying to
> figure out the monotone test suite setup just to get any useful action on
> fixing something that should always have worked and that any random user
> walking up to use mtn can't fathom wouldn't be entirely reliable and
> thoroughly tested in any SCM that isn't a joke, it's awesome for building
> community spirit.

I apologize; I didn't mean the request to be that off-putting.  The
thing is, I doubt anyone other than you or me will do it, and I was
guessing that it would be *easier* for you than me, because you know
exactly what doesn't work, whereas I have never tried mtn:// urls.  --
You may have noticed that there hasn't been a lot of activity here
lately.  I think the only person who's done serious development in a
while is Stephen Leake.  I want to spend more time on it but my day
job is eating all my hacking energy.

Anyway, I'll find time this weekend to merge your patch and some tests for it.

(Did it seriously take all day to figure out the test suite?  I know
it's not well documented but I didn't think it could be *that*
confusing.)

> I can't figure out why tests/netsync_mtn_uri_scheme doesn't get run
> already, or if it does, why it doesn't already fail the same way that I see
> when I try any simple manual use of a mtn:// uri.

Hmm.  Did you try urls of the form mtn://host?branch instead of
mtn://host/branch ?  That's the only thing I can think of.

>  It's too bad if no one
> else cares to look into this.  I think I'll spend what little time I can
> spare for improving monotone on trying to get a sensible packaged usher
> hosting server setup to work out of the box, rather than on this.

You might find the debian/monotone-server.* scripts helpful, although
I have no idea how much of that is applicable to Redhat-style systems
or to usher setups.  It would be great to make that stuff less
distro-specific.

zw