Re: [Monotone-devel] review of nvm.connection_info_cleanup

[Thomas Keller]

Am 18.06.2010 04:07, schrieb Timothy Brownawell:
> On 06/16/2010 03:29 AM, Thomas Keller wrote:
>>
>> Hi all!
>>
>> The branch nvm.connection_info_cleanup should be feature-complete from
>> my side, all tests pass and the docs have been updated accordingly.
>> Please read over it and give me feedback if you find gotchas or think of
>> other improvements.
> 
> [NEWS]
>> +        - Naturally, the `clone` command now also accepts mtn:// URIs,
>> +          though the usage of branch globs is forbidden, as long as
>> +          no branch is specified separately with the new --branch
>> option.
> 
> "...the use of branch globs is forbidden unless a branch is specified
> separately with the new --branch option."
> 
> [netsync.cc]
>> +  request.role = source_and_sink_role;
>> +  if (w == "sync")
>> +    request.role = source_and_sink_role;
>> +  else if (w == "push")
>> +    request.role = source_role;
>> +  else if (w == "pull")
>> +    request.role = sink_role;
> 
> 'w' here is a 'char*', which you cannot compare like this. One or the
> other argument needs to be turned into a std::string (or you can use
> strcmp, but that's icky).

Thanks, both issues have been corrected. If nobody else speaks up, I'll
merge this into mainline tonight or tomorrow.

Thomas.

-- 
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en

signature.asc
Description: OpenPGP digital signature