Re: [Monotone-devel] [bug #30150] annotate broken for files with revisions signed by disliked signers

[Stephen Leake]

Thomas Keller <address@hidden> writes:

> but I think annotate should be a bit smarter than outputting nothing,
> e.g. I thought it could output the string "<untrusted>" for each empty
> cert it encounters, so the output could be
>
>       86e0c6ba.. by <untrusted> 2010-01-01 : foo
>
> for untrusted author certs,
>
>       86e0c6ba.. by joe <untrusted>: foo
>
> for untrusted date certs and finally
>
>       86e0c6ba.. by <untrusted> <untrusted>: foo
>
> if both certs are untrusted.
>
> This is however a bit problematic, since we cannot distinguish at this
> point between untrusted and simply non-existing certs, as
> database::remove_bogus_certs plainly removed all invalid.
>
> So I thought about removing the call to project.db.erase_bogus_certs()
> and do the cert processing / evaluation in annotate.cc myself, but then
> this looked like a bit more work and might be not wanted...
>
> Opinions?

I think that for annotate, it is fine to output blank spaces. If a user
wants more info about a particular rev, they can use other commands (mtn
log, mtn automate certs, etc).

-- 
-- Stephe