Re: [Monotone-devel] nvm.source-tree-cleanup

[Timothy Brownawell]

On 01/30/2011 05:08 PM, Thomas Keller wrote:
> 
> Hi all!
> 
> Richard, Stephe and me polished the above branch over the last weeks and
> got positive response from a couple of people that it works well for
> them. For those who weren't following the previous development, this
> branch is basically about moving stuff around into specific directories,
> i.e. we now have a dedicated src/, test/ and doc/ directory and the
> in-tree documentation has been sanitized accordingly.
> 
> There are a couple of minor issues left which kind of block the merge
> back to nvm, one of them is the move of some innosetup-specific
> resources out of src/win32 and another one deals with HTML
> documentation. I'd still put the whole branch up for review now already
> because I really want to see the work merged back in nvm to get even
> more feedback and also to allow third parties (debian for example) adapt
> their source trees according to our Makefile.am changes.
> 
> So please have a look at the changes in this branch and give us
> feedback. If you think it is not a good idea to merge this into nvm yet,
> then please also tell us. In case nobody places serious objections I'd
> like to merge the branch by the end of next week (Friday'ish).

#include's use relative paths now, instead of absolute ("base.hh" in
src/ and "../base.hh" in src/network, rather than "src/base.hh"
everywhere) -- except config.h is still "config.h" (and since it lives
in the build directory, a relative path "../config.h" or
"../../config.h" won't work for it). I guess that seems reasonable.

A number of functions now have their return type reformatted onto a
separate line, that's perfectly fine but gives a bigger diff to look at.

"make distcheck" fails, apparently because "make doc/monotone.ps" fails
(but "make doc/monotone.pdf" works fine). This happens even with a
writable srcdir (ie, not limited to distcheck).

-- 
Timothy

Free public monotone hosting: http://mtn-host.prjek.net