Re: [Monotone-devel] A branch for FreeBSD 10's clang

[Lapo Luchini]

Lapo Luchini wrote:
> Tests on different platforms and suggestion are welcome.

Turned out to be easier than expected.

% mtn diff -r h:net.venge.monotone -r h:net.venge.monotone.freebsd-10


A few comments:

* m4/library.m4

I'm not sure which versions of pkg-config support "--variable=pc_path",
I only tried with FreeBSD and Cygwin, and they both do.
Cygwin supports "--debug" (that we're currently using) too, but
FreeBSD's doesn't. Also, it's easier this way.

* m4/tr1unorderedmap.m4
* src/hash_map.hh

A simple s/std::tr1::/std::/ replace.
I haven't checked why this work, I suppose stuff which was once
experimental now is standard or something like that.
Still works on Cygwin (as it wasn't using the TR1 code path anyways, and
still doesn't).

* src/automate_reader.cc
* src/automate_reader.hh

I moved <iostream> from .cc to .hh, or std::streamsize was unrecognized
there.

Looks to me we could probably merge all this into trunk, but I didn't
check any platform other than FreeBSD (gcc/clang, 32/64) and Cygwin/64.

-- 
Lapo Luchini - http://lapo.it/

“Optimists believe we live in the best world possible. Pessimists agree
to this.”