[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nmh-workers] Second release candidate for nmh 1.6 now available
From: |
Ken Hornstein |
Subject: |
Re: [Nmh-workers] Second release candidate for nmh 1.6 now available |
Date: |
Sun, 04 May 2014 09:35:08 -0400 |
> the dud "ISO-8859-" is the buffer initializer which i
> believe is caused by norm_charmap being asked to work on its own output.
>
> i've fixed this by malloc()ing that buffer; see attached patch.
Thanks! However ... that will result in a memory leak, yes? Okay,
you'll point out that nmh is terrible on memory management and I won't
disagree, but I don't think that's an excuse for making it worse.
Fixing this properly either means we need to be much more clever in
norm_charmap(), or always allocate a buffer and fix every caller of
norm_charmap(). Sigh.
--Ken