nmh-workers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Nmh-workers] small patch for test/inc/test-deb359167


From: Alexander Zangerl
Subject: [Nmh-workers] small patch for test/inc/test-deb359167
Date: Fri, 20 Mar 2015 22:32:58 +1000

a debian user reported that valgrind errors out on this particular test
(<http://bugs.debian.org/779947>); the root cause is not anything in nmh
but rather fakeroot, which is the standard build and 
test environment for debian packages.

however, that particular test totally ignores the shipped test/valgrind.supp.

i'd appreciate it if somebody with git commit rights would add the following
one-liner to make the test honor valgrind.supp:

---patch---
--- a/test/inc/test-deb359167
+++ b/test/inc/test-deb359167
@@ -36,4 +36,4 @@ fi
 
 chmod 755 ${MH_INST_DIR}${bindir}/inc
 
-valgrind --error-exitcode=1 --quiet inc -silent -file "$TESTMBOX"
+valgrind --error-exitcode=1 --quiet 
--suppressions="$MH_OBJ_DIR/test/valgrind.supp" inc -silent -file "$TESTMBOX"
---patch---

for completeness' sake here is the debian/fakeroot-specific addition to
test/valgrind.supp:

---patch---
--- a/test/valgrind.supp
+++ b/test/valgrind.supp
@@ -15,3 +15,20 @@
    fun:*sendmsg*
    fun:readline
 }
+
+{
+   Syscall param msgsnd(msgp->mtext) points to uninitialised byte(s) [under 
fakeroot]
+   Memcheck:Param
+   msgsnd(msgp->mtext)
+   ...
+   obj:*libfakeroot*.so
+}
+
+{
+ Syscall param stat(file_name) points to uninitialised byte(s) [under fakeroot]
+ Memcheck:Param
+ stat(file_name)
+ ...
+ obj:*libfakeroot*.so
+}
+
---patch---

regards,
az


-- 
Alexander Zangerl + GPG Key 0xB963BD5F (or 0x42BD645D) + http://snafu.priv.at/
[Unix] is not necessarily evil, like OS/2. - Peter Norton

Attachment: signature.asc
Description: Digital Signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]