[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #55446] Implementation of lightangle
From: |
Markus Mützel |
Subject: |
[Octave-bug-tracker] [bug #55446] Implementation of lightangle |
Date: |
Sat, 12 Jan 2019 07:44:44 -0500 (EST) |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0 |
Update of bug #55446 (project octave):
Severity: 1 - Wish => 3 - Normal
Item Group: Feature Request => Matlab Compatibility
_______________________________________________________
Follow-up Comment #2:
Thanks for your contribution. A couple of (minor) remarks:
- Instead of your local function "islight", I think you could just use
isgraphics (h, "light"). The same for the test: Instead of asserting the type,
you could use isgraphics with the type argument.
- Could you please add some documentation for the various input and output
argument options?
- Maybe test for specific error messages in the BISTs (see e.g. in
"camlight").
- It would be nice if you could create a full changeset that adds this
function at the location Kai indicated.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?55446>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/