[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #55788] pkg install no longer supports .zip ar
From: |
Mike Miller |
Subject: |
[Octave-bug-tracker] [bug #55788] pkg install no longer supports .zip archives |
Date: |
Tue, 26 Feb 2019 19:48:55 -0500 (EST) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.119 Safari/537.36 |
URL:
<https://savannah.gnu.org/bugs/?55788>
Summary: pkg install no longer supports .zip archives
Project: GNU Octave
Submitted by: mtmiller
Submitted on: Tue 26 Feb 2019 04:48:53 PM PST
Category: Octave Function
Severity: 3 - Normal
Priority: 5 - Normal
Item Group: Regression
Status: Confirmed
Assigned to: None
Originator Name:
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Release: 5.1.0
Operating System: Any
_______________________________________________________
Details:
In Octave 4.4 and older, "pkg install foo.zip" worked.
This is related to bug #54657 and
https://hg.savannah.gnu.org/hgweb/octave/rev/75ed70a1c108 fixing the 'unpack'
function. I think that bug fix is entirely accurate, but it did not account
for this regression in the 'pkg' function.
The 'pkg' subfunction 'install.m' uses the 'untar' function, regardless of the
input file. This used to work even on .zip files, which is weird, but that is
the cause of this regression.
Possible appropriate fixes:
* change 'untar' to 'unpack' and let it always use file extension
* add if-else to call 'unzip' or 'untar' depending on file extension
The second may be better and is definitely less risky, only use 'unzip' if the
file ends with '.zip', always fall back to 'untar' to work the way the
function used to. It also consistently uses Matlab compatible functions
'untar' and 'unzip', 'unpack' is Octave specific.
Originally reported at
https://lists.gnu.org/archive/html/octave-maintainers/2019-02/msg00198.html.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?55788>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #55788] pkg install no longer supports .zip archives,
Mike Miller <=