octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Stories from static analysis of the Octave code base


From: John W. Eaton
Subject: Re: Stories from static analysis of the Octave code base
Date: Fri, 4 Jan 2019 15:19:27 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 1/4/19 2:35 PM, Rik wrote:
All,

It's been a humbling experience going through the issues detected by static
analysis of the Octave code base
(https://wiki.octave.org/PVS_static_analyzer_-_5.0_Release).  Frankly, I
thought the code base was better than it turned out to be.  Besides flat
out calling the wrong function (e.g., double_value instead of
xdouble_value), I just found and corrected a surprisingly simple but
pervasive performance hit for any exceptional value (-Inf, Inf, NaN).

Well, that's embarrassing.  I probably made the original mistake.  Oops.

But I don't think we should be too hard on ourselves. It is a bit disappointing to find mistakes like this, but I'm glad that things are improving. And I think we have made a lot of progress in the last few years to make Octave much better than it was.

jwe



reply via email to

[Prev in Thread] Current Thread [Next in Thread]