Re: warnings when installing the control pkg

[Mike Miller]

On Thu, Jan 10, 2019 at 12:49:51 -0500, Doug Stewart wrote:
> was it wrong for me to replace
> OCTAVE_IDX_TYPE  with int

I fixed the same thing in the signal package with

@@ -361,7 +360,8 @@ to bring them up to size @var{n}.\n\
                      args(3).double_value ());
             //if (dim < 1 || dim > signal.dims ().length ())
             if (dim < 1)
-              error ("medfilt1: DIM must be positive, not %d", dim);
+              error ("medfilt1: DIM must be positive, not %ld",
+                     static_cast<long> (dim));
           }
         else
           error ("medfilt1: Invalid type for DIM: %s",

I think it's better to keep it an octave_idx_type. Maybe in a future
version of Octave we can rely on octave_idx_type being the same as
either size_t or ssize_t.

-- 
mike

signature.asc
Description: PGP signature