Re: Aw: Re: Default line endings on Mac

[Torsten]

On 10.01.19 20:50, Andrew Janke wrote:
> 
> 
> On 1/10/19 2:45 PM, Torsten wrote:
>> On 10.01.19 20:21, "Markus Mützel" wrote:
>>> Am Donnerstag, 10. Januar 2019 um 19:57 Uhr schrieb "John W. Eaton":
>>>
>>> The attached patch should change the default EOL to LF for Mac.
>>> But I don't have a Mac to check if it actually works.
>>>
>>>> Do we currently detect the line endings in the file and try to match
>>>> the
>>>> usage?  If not, should we?  How difficult would it be?
>>>
>>> I believe such a check is already done in
>>> file_editor_tab::detect_eol_mode.
>>>
>>>> Now, if Windows would just abandon CRLF in favor of LF only...
>>>
>>> I hear you. And UTF-8 as a working encoding. Or better yet the
>>> default...
>>>
>>> Markus
>>>
>>
>> Markus, the patch looks good. However, I can't test it either.
>>
>> Torsten
> 
> I tested the patch on macOS 10.13.6 and it looks good. After blowing
> away my
> ~/.config/octave to get a clean slate, it defaulted to using Unix (LF)
> as the line ending format.
> 
> Cheers,
> Andrew
> 

Andrew, thanks for testing.
Markus, could you then please push your patch?

Torsten