[Octave-patch-tracker] [patch #10344] Experimental stack VM for GNU Octave

[Petter T.]

Follow-up Comment #2, patch #10344 (project octave):

[comment #1 comment #1:]
> However, I see a lot of warnings while running the test suite that I don't
remember seeing before. [...] 
> Is handling Octave warnings affected by the VM?

It should not affect anything if it is working properly. I.e. very few
functions 'know' that the VM is running or calling them.
'__run_test_suite__' sets 'quiet' on for warnings, so those warnings should
not be printed.

I looked into that and it seems like the VM does not restore the stack frame's
'auto var' SAVED_WARNING_STATES when unwinding it-self.
One of the tests enables warnings with the "local" option, which turned on
warnings for the rest of the test-suite, rather than
disabling them again when unwinding the frame.

Running some test manually it seems like the VM gives the same warnings as no
VM.

I have fixed that and will clean up the patch and submit it here at some
point.

> 
> I didn't look into the changes in any detail. Just a rather "nitty" remark:
We usually don't claim copyright for past years when new files are added.
>

Makes sense =)


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10344>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/