Re: [pdf-devel] Hi. Want to join development

[Aleksander Morgado]

Hi Gustavo,

> 
> I'd like to join development. It's my first GNU project, so I just read
> the docs, the source and took a task from the task list. It's "FS#130 -
> Write new hash helpers for integer values".
> 

There's already a patch for that task in the ML, see:
http://lists.gnu.org/archive/html/pdf-devel/2011-05/msg00037.html

Not yet in trunk though, should get into soon.


> I read in the flyspray that ints should be casted to pointers as in the
> code of add/get_bool(). Now I found two problems:
> 
> 1- The compiler warns me about casting between different sizes (I'm
> running on an i64 arch). 

The patch in the ML doesn't probably cover that case. Possibly need to
cast the int to long before putting it in a (void *), and the other way
around when getting the value. Could you apply the patch in a local
branch and check if those extra casts to (long) are enough?

> 2- If key is not found I don't know what to return.
> 

I would return 0, and warn about that in the documentation.

Cheers!

-- 
Aleksander

signature.asc
Description: This is a digitally signed message part