[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: type 3 patches
From: |
Jason Stover |
Subject: |
Re: type 3 patches |
Date: |
Mon, 17 Jan 2011 12:05:59 -0500 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Mon, Jan 17, 2011 at 01:27:29PM +0000, John Darrington wrote:
> My initial reaction is to prefer the first patch. It seems simpler.
>
> However I'm a bit confused about this :
>
> + gsl_vector_set (result, dropped,
> + gsl_matrix_get (small_cov, 0, 0)
> + - gsl_matrix_get (small_cov, 0, 0));
>
> Doesn't that mean that the result will always be the zero vector?
Yes, it should be gsl_matrix_get (small_cov, 0, 0) - sse. I'll test
it before committing.
> To answer the question about in which file to put the function, I suggest
> that for now we put it in glm.c That's where we know it's going to be used.
> We can move it later if necessary.
OK, I'll start on it.
-Jason