Re: [Qemu-arm] [Qemu-devel] [PATCH 0/4] target/arm: Implement ARMv8.2-FHM

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/4] target/arm: Implement ARMv8.2-FHM
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
10aad4eb81 target/arm: Enable ARMv8.2-FHM for -cpu max
ff95a88ae6 target/arm: Implement VFMAL and VFMSL for aarch32
598963ad45 target/arm: Implement FMLAL and FMLSL for aarch64
4399afe237 target/arm: Add helpers for FMLAL and FMLSL

=== OUTPUT BEGIN ===
1/4 Checking commit 4399afe237f0 (target/arm: Add helpers for FMLAL and FMLSL)
ERROR: spaces required around that '*' (ctx:VxV)
#130: FILE: target/arm/vec_helper.c:856:
+        d[H4(i)] = fmlal(d[H4(i)], extract64(n_4, i*16, 16),
                                                    ^

ERROR: spaces required around that '*' (ctx:VxV)
#131: FILE: target/arm/vec_helper.c:857:
+                         extract64(m_4, i*16, 16), fpst);
                                          ^

ERROR: spaces required around that '*' (ctx:VxV)
#150: FILE: target/arm/vec_helper.c:876:
+        d[H4(i)] = fmlsl(d[H4(i)], extract64(n_4, i*16, 16),
                                                    ^

ERROR: spaces required around that '*' (ctx:VxV)
#151: FILE: target/arm/vec_helper.c:877:
+                         extract64(m_4, i*16, 16), fpst);
                                          ^

ERROR: spaces required around that '*' (ctx:VxV)
#193: FILE: target/arm/vec_helper.c:919:
+        d[H4(i)] = fmlsl(d[H4(i)], extract64(n_4, i*16, 16), m_1, fpst);
                                                    ^

total: 5 errors, 0 warnings, 172 lines checked

Patch 1/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/4 Checking commit 598963ad4504 (target/arm: Implement FMLAL and FMLSL for 
aarch64)
3/4 Checking commit ff95a88ae603 (target/arm: Implement VFMAL and VFMSL for 
aarch32)
4/4 Checking commit 10aad4eb81e8 (target/arm: Enable ARMv8.2-FHM for -cpu max)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden