[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 3/8] target/arm/cpu: Allow init-svtor
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 3/8] target/arm/cpu: Allow init-svtor property to be set after realize |
|
Date: |
Wed, 20 Feb 2019 10:15:58 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/19/19 4:58 AM, Peter Maydell wrote:
> +static void arm_set_init_svtor(Object *obj, Visitor *v, const char *name,
> + void *opaque, Error **errp)
> +{
> + ARMCPU *cpu = ARM_CPU(obj);
> +
> + visit_type_uint32(v, name, &cpu->init_svtor, errp);
> +}
Since there's no validation needed, can this use object_property_add_uint32_ptr?
That said, this isn't wrong so,
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-arm] [PATCH 0/8] ARMSSE: Implement MHUs and dual-core capability, Peter Maydell, 2019/02/19
- [Qemu-arm] [PATCH 1/8] hw/misc/armsse-mhu.c: Model the SSE-200 Message Handling Unit, Peter Maydell, 2019/02/19
- [Qemu-arm] [PATCH 3/8] target/arm/cpu: Allow init-svtor property to be set after realize, Peter Maydell, 2019/02/19
- Re: [Qemu-arm] [Qemu-devel] [PATCH 3/8] target/arm/cpu: Allow init-svtor property to be set after realize,
Richard Henderson <=
- [Qemu-arm] [PATCH 4/8] target/arm/arm-powerctl: Add new arm_set_cpu_on_and_reset(), Peter Maydell, 2019/02/19
- [Qemu-arm] [PATCH 2/8] hw/arm/armsse: Wire up the MHUs, Peter Maydell, 2019/02/19
- [Qemu-arm] [PATCH 5/8] hw/misc/iotkit-sysctl: Correct typo in INITSVTOR0 register name, Peter Maydell, 2019/02/19
- [Qemu-arm] [PATCH 8/8] hw/arm/armsse: Unify init-svtor and cpuwait handling, Peter Maydell, 2019/02/19
- [Qemu-arm] [PATCH 6/8] hw/arm/iotkit-sysctl: Add SSE-200 registers, Peter Maydell, 2019/02/19