qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] [rpi4b] Make bootable rpi4b model


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] [rpi4b] Make bootable rpi4b model
Date: Mon, 22 May 2023 15:41:53 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 22/5/23 14:41, Kambalin, Sergey wrote:

Could you please tell me what size is appropriate for a single patch?

The most important things for patch splitting are:
  * everything still has to compile cleanly
  * the contents of a single patch should be a coherent single
    thing that it makes sense to review in one part

If there's something in there that only touches 20 lines of
code but is a coherent single change, it's fine to have that in
its own patch -- small patches are easy to review.

At the upper end, I tend to think a patch is a bit big
at around 200 lines, but for the specific case of "here
is a new device" bigger than that is OK, because it's
just adding new files rather than merging changes into
existing ones.

https://www.qemu.org/docs/master/devel/submitting-a-patch.html <https://www.qemu.org/docs/master/devel/submitting-a-patch.html>
has some other advice on patch submission, if you haven't
read that yet.

FWIW example of series adding the Pi Zero:

https://lore.kernel.org/qemu-devel/20201024170127.3592182-1-f4bug@amsat.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]