Re: [PATCH v5 2/3] tests/qtest: Add STM32L4x5 EXTI QTest testcase

[inesvarhol]

Le jeudi 4 janvier 2024 à 14:05, Philippe Mathieu-Daudé <philmd@linaro.org> a 
écrit :

Hello,

> > +static void test_edge_selector(void)
> > +{
> > + enable_nvic_irq(EXTI0_IRQ);
> > +
> > + / Configure EXTI line 0 irq on rising edge */
> > + qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti",
> 
> 
> Markus, this qtest use seems to expect some stability in QOM path...
> 
> Inès, Arnaud, having the SoC unattached is dubious, it belongs to
> the machine.

Noted, we will fix that. 
Should we be concerned about the "stability in QOM path" ?

> 
> (qemu) info qom-tree
> /machine (b-l475e-iot01a-machine)
> /SYSCLK (clock)
> /peripheral (container)
> /peripheral-anon (container)
> /unattached (container)
> /device[0] (stm32l4x5xg-soc)
> 
> Eh I don't see the 'exti' here...
> 
> Indeed the test fails:
> 
> 17/35 qemu:qtest+qtest-arm / qtest-arm/test-arm-mptimer
> OK 0.44s 61 subtests passed
> ▶ 18/35 /arm/stm32l4x5/exti/reg_write_read
> FAIL
> ▶ 18/35 /arm/stm32l4x5/exti/no_software_interrupt
> FAIL
> ▶ 18/35 /arm/stm32l4x5/exti/software_interrupt
> FAIL
> ▶ 18/35 /arm/stm32l4x5/exti/masked_interrupt
> FAIL
> ▶ 18/35 /arm/stm32l4x5/exti/interrupt
> FAIL
> ▶ 18/35 /arm/stm32l4x5/exti/test_edge_selector
> FAIL
> Listing only the last 100 lines from a long log.

Yes indeed, the tests fail in this 2nd commit as the EXTI device isn't 
connected to the SoC yet (3rd commit).
I forgot to mention it in this in this version :/
Swapping the 2nd and 3rd commmit seems more straightforward to do ?