Re: [Qemu-block] [PATCH 1/1] include: Auto-generate the sizes lookup table

[Leonid Bloch]

Hi Phil,

Thanks for your review! Very valid points. All taken, except the naming 
(I think "pow2_sizes.h" would be better than "lookup_table_sizes.h", 
no?) and the "generated" directory - I agree that it's a good idea, but 
I think it requires a separate patch which moves the generated files there.

Regards,
Leonid.

On 1/3/19 12:33 PM, Philippe Mathieu-Daudé wrote:
> 
> So as 'module_block.h', why not simply name it 'lookup_table_sizes.h'?
> 
> Actually, we could move those in a generated/ subdirectory, this
> would make the source file more explicit:
> 
> #include "generated/module_block.h"
> 
> Kevin, what do you think?
>