[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 14/19] nbd/client: Pull out oldstyle size det
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v3 14/19] nbd/client: Pull out oldstyle size determination |
Date: |
Wed, 16 Jan 2019 13:47:50 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 1/15/19 9:35 AM, Vladimir Sementsov-Ogievskiy wrote:
> 12.01.2019 20:58, Eric Blake wrote:
>> Another refactoring creating nbd_negotiate_finish_oldstyle()
>> for further reuse during 'qemu-nbd --list'.
>>
>> Signed-off-by: Eric Blake <address@hidden>
>> Message-Id: <address@hidden>
>> Reviewed-by: Richard W.M. Jones <address@hidden>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>
> Hmm, looking at this, I found that nbd_start_negotiate() has very unusual
> semantics
> for @zeroes field, without any comment about it:
>
> It must be set to true before calling, and nbd_start_negotiate may set it to
> true.
>
> I think better is not to rely on caller initialization and set zeroes to true
> at the
> beginning of nbd_start_negotiate().
Makes sense; done in my local tree.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v3 04/19] nbd/server: Hoist length check to qemp_nbd_server_add, (continued)
Re: [Qemu-block] [Qemu-devel] [PATCH v3 04/19] nbd/server: Hoist length check to qemp_nbd_server_add, Eric Blake, 2019/01/16
[Qemu-block] [PATCH v3 06/19] qemu-nbd: Avoid strtol open-coding, Eric Blake, 2019/01/12
[Qemu-block] [PATCH v3 14/19] nbd/client: Pull out oldstyle size determination, Eric Blake, 2019/01/12
[Qemu-block] [PATCH v3 02/19] qemu-nbd: Enhance man page, Eric Blake, 2019/01/12
[Qemu-block] [PATCH v3 11/19] nbd/client: Split out nbd_receive_one_meta_context(), Eric Blake, 2019/01/12
Re: [Qemu-block] [PATCH v3 00/19] nbd: add qemu-nbd --list, Vladimir Sementsov-Ogievskiy, 2019/01/14
Re: [Qemu-block] [PATCH v3 00/19] nbd: add qemu-nbd --list, Vladimir Sementsov-Ogievskiy, 2019/01/17