[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PULL 11/20] iotests: add iotest 236 for testing bitmap
From: |
John Snow |
Subject: |
Re: [Qemu-block] [PULL 11/20] iotests: add iotest 236 for testing bitmap merge |
Date: |
Wed, 30 Jan 2019 12:58:19 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 1/30/19 12:27 PM, Kevin Wolf wrote:
> Am 14.01.2019 um 17:25 hat Eric Blake geschrieben:
>> From: John Snow <address@hidden>
>>
>> New interface, new smoke test.
>>
>> Signed-off-by: John Snow <address@hidden>
>> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>> Message-Id: <address@hidden>
>> [eblake: fix last-minute change to echo text]
>> Signed-off-by: Eric Blake <address@hidden>
>
> This test fails for me (with Python 3) because I get a different dict
> order.
>
> Probably related to the OrderedDict that qmp_log() uses, so log() uses
> sort_keys=False and the unordered dicts that are contained in the outer
> OrderedDict stay unordered.
>
> Kevin
>
Gurg. Sorry, apparently Python is hard. Will fix.