[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v13 01/31] block: Use bdrv_refresh_
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v13 01/31] block: Use bdrv_refresh_filename() to pull |
Date: |
Fri, 1 Feb 2019 13:52:13 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/1/19 1:29 PM, Max Reitz wrote:
> Before this patch, bdrv_refresh_filename() is used in a pushing manner:
> Whenever the BDS graph is modified, the parents of the modified edges
> are supposed to be updated (recursively upwards). However, that is
> nonviable, considering that we want child changes not to concern
> parents.
>
> Also, in the long run we want a pull model anyway: Here, we would have a
> bdrv_filename() function which returns a BDS's filename, freshly
> constructed.
>
> This patch is an intermediate step. It adds bdrv_refresh_filename()
> calls before every place a BDS.filename value is used. The only
> exceptions are protocol drivers that use their own filename, which
> clearly would not profit from refreshing that filename before.
>
> Also, bdrv_get_encrypted_filename() is removed along the way (as a user
> of BDS.filename), since it is completely unused.
>
> In turn, all of the calls to bdrv_refresh_filename() before this patch
> are removed, because we no longer have to call this function on graph
> changes.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v13 00/31] Fix some filename generation issues, Max Reitz, 2019/02/01
- [Qemu-block] [PATCH v13 03/31] block: Skip implicit nodes for filename info, Max Reitz, 2019/02/01
- [Qemu-block] [PATCH v13 06/31] iotests.py: Add filter_imgfmt(), Max Reitz, 2019/02/01
- [Qemu-block] [PATCH v13 02/31] block: Use children list in bdrv_refresh_filename, Max Reitz, 2019/02/01
- [Qemu-block] [PATCH v13 07/31] iotests.py: Add node_info(), Max Reitz, 2019/02/01
- [Qemu-block] [PATCH v13 01/31] block: Use bdrv_refresh_filename() to pull, Max Reitz, 2019/02/01
- Re: [Qemu-block] [Qemu-devel] [PATCH v13 01/31] block: Use bdrv_refresh_filename() to pull,
Eric Blake <=
- [Qemu-block] [PATCH v13 04/31] block: Add BDS.auto_backing_file, Max Reitz, 2019/02/01
- [Qemu-block] [PATCH v13 05/31] block: Respect backing bs in bdrv_refresh_filename, Max Reitz, 2019/02/01
- [Qemu-block] [PATCH v13 09/31] block: Make path_combine() return the path, Max Reitz, 2019/02/01
- [Qemu-block] [PATCH v13 10/31] block: bdrv_get_full_backing_filename_from_...'s ret. val., Max Reitz, 2019/02/01
- [Qemu-block] [PATCH v13 08/31] iotests: Add test for backing file overrides, Max Reitz, 2019/02/01
- [Qemu-block] [PATCH v13 12/31] block: Add bdrv_make_absolute_filename(), Max Reitz, 2019/02/01
- [Qemu-block] [PATCH v13 11/31] block: bdrv_get_full_backing_filename's ret. val., Max Reitz, 2019/02/01
- [Qemu-block] [PATCH v13 13/31] block: Fix bdrv_find_backing_image(), Max Reitz, 2019/02/01
- [Qemu-block] [PATCH v13 14/31] block: Add bdrv_dirname(), Max Reitz, 2019/02/01
- [Qemu-block] [PATCH v13 16/31] quorum: Make bdrv_dirname() return NULL, Max Reitz, 2019/02/01