[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PULL 0/9] Block patches
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-block] [PULL 0/9] Block patches |
|
Date: |
Tue, 12 Feb 2019 11:51:18 +0800 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Feb 11, 2019 at 11:42:14AM +0000, Peter Maydell wrote:
> On Mon, 11 Feb 2019 at 05:50, Stefan Hajnoczi <address@hidden> wrote:
> >
> > The following changes since commit e47f81b617684c4546af286d307b69014a83538a:
> >
> > Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into
> > staging (2019-02-07 18:53:25 +0000)
> >
> > are available in the Git repository at:
> >
> > git://github.com/stefanha/qemu.git tags/block-pull-request
> >
> > for you to fetch changes up to 55140166667bb555c5d05165b93b25557d2e6397:
> >
> > tests/virtio-blk: add test for WRITE_ZEROES command (2019-02-11 11:58:17
> > +0800)
> >
> > ----------------------------------------------------------------
> > Pull request
> >
> > User-visible changes:
> >
> > * virtio-blk: DISCARD and WRITE_ZEROES support
>
> Hi; this fails to pass "make check" (all platforms):
>
> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> QTEST_QEMU_BINARY=arm-softmmu/qemu-system-arm QTEST_QEMU_IMG=qemu-img
> tests/virtio-blk-test -m
> =quick -k --tap < /dev/null | ./scripts/tap-driver.pl
> --test-name="virtio-blk-test"
> **
> ERROR:/home/pm215/qemu/tests/virtio-blk-test.c:272:test_basic:
> assertion failed (status == 0): (1 == 0)
> ERROR - too few tests run (expected 1, got 0)
Stefano, I'm dropping the virtio-blk DISCARD/WRITE_ZEROES series.
Please debug this failure.
I cannot reproduce it on a Linux host so maybe it's related to macOS.
First I thought it's because write zeroes is not supported on macOS, but
QEMU should fall back to writing a bounce buffer of zeroes.
Stefan
signature.asc
Description: PGP signature
- [Qemu-block] [PULL 3/9] virtio-blk: cleanup using VirtIOBlock *s and VirtIODevice *vdev, (continued)
- [Qemu-block] [PULL 3/9] virtio-blk: cleanup using VirtIOBlock *s and VirtIODevice *vdev, Stefan Hajnoczi, 2019/02/11
- [Qemu-block] [PULL 4/9] virtio-blk: add acct_failed param to virtio_blk_handle_rw_error(), Stefan Hajnoczi, 2019/02/11
- [Qemu-block] [PULL 5/9] virtio-blk: add host_features field in VirtIOBlock, Stefan Hajnoczi, 2019/02/11
- [Qemu-block] [PULL 6/9] virtio-blk: add "discard" and "write-zeroes" properties, Stefan Hajnoczi, 2019/02/11
- [Qemu-block] [PULL 7/9] virtio-blk: add DISCARD and WRITE_ZEROES features, Stefan Hajnoczi, 2019/02/11
- [Qemu-block] [PULL 8/9] tests/virtio-blk: change assert on data_size in virtio_blk_request(), Stefan Hajnoczi, 2019/02/11
- [Qemu-block] [PULL 9/9] tests/virtio-blk: add test for WRITE_ZEROES command, Stefan Hajnoczi, 2019/02/11
- [Qemu-block] [PULL 1/9] iothread: fix iothread hang when stop too soon, Stefan Hajnoczi, 2019/02/11
- [Qemu-block] [PULL 2/9] qemugdb/coroutine: fix arch_prctl has unknown return type, Stefan Hajnoczi, 2019/02/11
- Re: [Qemu-block] [PULL 0/9] Block patches, Peter Maydell, 2019/02/11
- Re: [Qemu-block] [PULL 0/9] Block patches,
Stefan Hajnoczi <=