[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 1/6] block/dirty-bitmap: add recording and bu
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v2 1/6] block/dirty-bitmap: add recording and busy properties |
Date: |
Wed, 13 Feb 2019 20:54:38 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/13/19 5:23 PM, John Snow wrote:
> The current API allows us to report a single status, which we've defined as:
>
> Frozen: has a successor, treated as qmp_locked, may or may not be enabled.
> Locked: no successor, qmp_locked. may or may not be enabled.
> Disabled: Not frozen or locked, disabled.
> Active: Not frozen, locked, or disabled.
>
> The problem is that both "Frozen" and "Locked" mean nearly the same thing,
> and that both of them do not intuit whether they are recording guest writes
> or not.
>
> This patch deprecates that status field and introduces two orthogonal
> properties instead to replace it.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> block/dirty-bitmap.c | 9 +++++++++
> qapi/block-core.json | 10 +++++++++-
> qemu-deprecated.texi | 6 ++++++
> tests/qemu-iotests/236.out | 28 ++++++++++++++++++++++++++++
> 4 files changed, 52 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-block] [PATCH v2 3/6] block/dirty-bitmap: change semantics of enabled predicate, John Snow, 2019/02/13