[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 01/10] pflash: Rename pflash_t to PFlashCFI01, P
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-block] [PATCH 01/10] pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02 |
Date: |
Mon, 18 Feb 2019 17:40:27 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 02/18/19 13:56, Markus Armbruster wrote:
> flash.h's incomplete struct pflash_t is completed both in
> pflash_cfi01.c and in pflash_cfi02.c. The complete types are
> incompatible.
O_o
> This can hide type errors, such as passing a pflash_t
> created with pflash_cfi02_register() to pflash_cfi01_get_memory().
>
> Furthermore, POSIX reserves typedef names ending with _t.
>
> Rename the two structs to PFlashCFI01 and PFlashCFI02.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> hw/arm/vexpress.c | 8 ++--
> hw/block/pflash_cfi01.c | 87 +++++++++++++++++++++-------------------
> hw/block/pflash_cfi02.c | 67 ++++++++++++++++---------------
> hw/i386/pc_sysfw.c | 2 +-
> hw/mips/mips_malta.c | 2 +-
> hw/xtensa/xtfpga.c | 10 ++---
> include/hw/block/flash.h | 53 ++++++++++++++----------
> 7 files changed, 122 insertions(+), 107 deletions(-)
I didn't check larger contexts in the modified files. I also didn't look
for typos or try to verify the patch by recreating it from scratch, and
by comparison. I read through the posted patch and it looks OK to me.
Reviewed-by: Laszlo Ersek <address@hidden>
Thanks
Laszlo
- Re: [Qemu-block] [Qemu-devel] [PATCH 02/10] pflash: Macro PFLASH_BUG() is used just once, expand, (continued)
- Re: [Qemu-block] [Qemu-devel] [PATCH 02/10] pflash: Macro PFLASH_BUG() is used just once, expand, Peter Maydell, 2019/02/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 02/10] pflash: Macro PFLASH_BUG() is used just once, expand, Laszlo Ersek, 2019/02/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 02/10] pflash: Macro PFLASH_BUG() is used just once, expand, Philippe Mathieu-Daudé, 2019/02/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 02/10] pflash: Macro PFLASH_BUG() is used just once, expand, Laszlo Ersek, 2019/02/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 02/10] pflash: Macro PFLASH_BUG() is used just once, expand, Philippe Mathieu-Daudé, 2019/02/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 02/10] pflash: Macro PFLASH_BUG() is used just once, expand, Markus Armbruster, 2019/02/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 02/10] pflash: Macro PFLASH_BUG() is used just once, expand, Alex Bennée, 2019/02/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 02/10] pflash: Macro PFLASH_BUG() is used just once, expand, Markus Armbruster, 2019/02/22
- Re: [Qemu-block] [Qemu-devel] [PATCH 02/10] pflash: Macro PFLASH_BUG() is used just once, expand, Alex Bennée, 2019/02/21
[Qemu-block] [PATCH 01/10] pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02, Markus Armbruster, 2019/02/18
- Re: [Qemu-block] [PATCH 01/10] pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02,
Laszlo Ersek <=
- Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02, Philippe Mathieu-Daudé, 2019/02/19
- Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02, Markus Armbruster, 2019/02/19
- Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02, Philippe Mathieu-Daudé, 2019/02/19
- Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02, Markus Armbruster, 2019/02/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02, Philippe Mathieu-Daudé, 2019/02/21
Re: [Qemu-block] [PATCH 01/10] pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02, Alex Bennée, 2019/02/21
Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups, no-reply, 2019/02/18
Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups, no-reply, 2019/02/18
Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups, no-reply, 2019/02/18
Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups, no-reply, 2019/02/18