|
From: | Markus Armbruster |
Subject: | Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img: fix error reporting for -object |
Date: | Tue, 19 Feb 2019 14:10:18 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Daniel P. Berrangé <address@hidden> writes: > Error reporting for user_creatable_add_opts_foreach was changed so that > it no longer called 'error_report_err' in: > > commit 7e1e0c11127bde81cff260fc6859690435c509d6 > Author: Markus Armbruster <address@hidden> > Date: Wed Oct 17 10:26:43 2018 +0200 > > qom: Clean up error reporting in user_creatable_add_opts_foreach() > > Some callers were updated to pass in "&error_fatal" but all the ones in > qemu-img were left passing NULL. As a result all errors went to > /dev/null instead of being reported to the user. > > Signed-off-by: Daniel P. Berrangé <address@hidden> Mea culpa, I have no idea how this happened. Reviewed-by: Markus Armbruster <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |