[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 05/10] nbd: change error checking order for b
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH v3 05/10] nbd: change error checking order for bitmaps |
|
Date: |
Sat, 23 Feb 2019 15:29:33 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 2/22/19 6:06 PM, John Snow wrote:
> Check that the bitmap is not in use prior to it checking if it is
> not enabled/recording guest writes. The bitmap being busy was likely
> at the behest of the user, so this error has a greater chance of being
> understood by the user.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> nbd/server.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- Re: [Qemu-block] [PATCH v3 04/10] block/dirty-bitmap: change semantics of enabled predicate, (continued)
- [Qemu-block] [PATCH v3 08/10] block/dirty-bitmaps: move comment block, John Snow, 2019/02/22
- [Qemu-block] [PATCH v3 09/10] blockdev: remove unused paio parameter documentation, John Snow, 2019/02/22
- [Qemu-block] [PATCH v3 06/10] block/dirty-bitmap: explicitly lock bitmaps with successors, John Snow, 2019/02/22
- [Qemu-block] [PATCH v3 05/10] nbd: change error checking order for bitmaps, John Snow, 2019/02/22
- [Qemu-block] [PATCH v3 10/10] iotests: add busy/recording bit test to 124, John Snow, 2019/02/22
- [Qemu-block] [PATCH v3 07/10] block/dirty-bitmaps: unify qmp_locked and user_locked calls, John Snow, 2019/02/22
- [Qemu-block] [PATCH v3 03/10] block/dirty-bitmap: remove set/reset assertions against enabled bit, John Snow, 2019/02/22