[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 3/4] block/dirty-bitmaps: add block_dirty_bit
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v2 3/4] block/dirty-bitmaps: add block_dirty_bitmap_check function |
Date: |
Mon, 25 Feb 2019 09:07:23 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 2/25/19 8:59 AM, Vladimir Sementsov-Ogievskiy wrote:
>
> And one more important question: we now creating new qapi bitmap status,
> consisting of several bool fields.
> Shouldn't we instead implement it as an array of flags?
Parsing:
{ "busy": false, "persistent": false, "recording": true }
is easier than parsing:
{ "flags": [ "recording" ] }
(and knowing that unlisted flags "busy", "persistent", and
"inconsistent" are false), or:
{ "flags": [ { "busy": false }, { "persistent": false }, { "recording":
true } ] }
So without more reason why an array of flags would be needed, I don't
see the point for it.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- Re: [Qemu-block] [PATCH v2 1/4] block/dirty-bitmaps: add inconsistent bit, (continued)