[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] block/io_uring: revert "Use io_uring_register_ring_fd() to s
|
From: |
Kevin Wolf |
|
Subject: |
Re: [PATCH] block/io_uring: revert "Use io_uring_register_ring_fd() to skip fd operations" |
|
Date: |
Fri, 21 Oct 2022 11:48:30 +0200 |
Am 24.09.2022 um 16:48 hat Sam Li geschrieben:
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1193
>
> The commit "Use io_uring_register_ring_fd() to skip fd operations" broke
> when booting a guest with iothread and io_uring. That is because the
> io_uring_register_ring_fd() call is made from the main thread instead of
> IOThread where io_uring_submit() is called. It can not be guaranteed
> to register the ring fd in the correct thread or unregister the same ring
> fd if the IOThread is disabled. This optimization is not critical so we
> will revert previous commit.
>
> This reverts commit e2848bc574fe2715c694bf8fe9a1ba7f78a1125a
> and 77e3f038af1764983087e3551a0fde9951952c4d.
>
> Signed-off-by: Sam Li <faithilikerun@gmail.com>
Thanks, applied to the block branch.
Kevin