qemu-block
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 09/43] hw/usb/hcd-uhci: Introduce TYPE_ defines for device

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 09/43] hw/usb/hcd-uhci: Introduce TYPE_ defines for device models
Date: Thu, 27 Oct 2022 22:57:18 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 
On 22/10/22 17:04, Bernhard Beschow wrote:

Suggested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
  hw/i386/pc_piix.c |  3 ++-
  hw/i386/pc_q35.c  | 13 +++++++------
  hw/isa/piix4.c    |  2 +-
  hw/usb/hcd-uhci.c | 16 ++++++++--------
  hw/usb/hcd-uhci.h |  9 +++++++++
  5 files changed, 27 insertions(+), 16 deletions(-)



diff --git a/hw/usb/hcd-uhci.h b/hw/usb/hcd-uhci.h
index c85ab7868e..22f6e6fcfc 100644
--- a/hw/usb/hcd-uhci.h
+++ b/hw/usb/hcd-uhci.h
@@ -91,4 +91,13 @@ typedef struct UHCIInfo {
  void uhci_data_class_init(ObjectClass *klass, void *data);
  void usb_uhci_common_realize(PCIDevice *dev, Error **errp);
+#define TYPE_PIIX3_USB_UHCI "piix3-usb-uhci" 
+#define TYPE_PIIX4_USB_UHCI "piix4-usb-uhci"
+#define TYPE_ICH9_USB_UHCI1 "ich9-usb-uhci1"
+#define TYPE_ICH9_USB_UHCI2 "ich9-usb-uhci2"
+#define TYPE_ICH9_USB_UHCI3 "ich9-usb-uhci3"
+#define TYPE_ICH9_USB_UHCI4 "ich9-usb-uhci4"
+#define TYPE_ICH9_USB_UHCI5 "ich9-usb-uhci5"
+#define TYPE_ICH9_USB_UHCI6 "ich9-usb-uhci6"


What about defining once:

  #define TYPE_ICH9_USB_UHCI(fn) "ich9-usb-uhci" #fn

?
reply via email to
[Prev in Thread] Current Thread [Next in Thread]