qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 12/17] qapi: Rewrite parsing of doc comment section symbols a


From: Markus Armbruster
Subject: Re: [PATCH 12/17] qapi: Rewrite parsing of doc comment section symbols and tags
Date: Tue, 09 May 2023 09:27:19 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Juan Quintela <quintela@redhat.com> writes:

> Markus Armbruster <armbru@redhat.com> wrote:
>> To recognize a line starting with a section symbol and or tag, we
>> first split it at the first space, then examine the part left of the
>> space.  We can just as well examine the unsplit line, so do that.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
>
> My python regexp kungfu is at the limit with this patch, so take it as
> you wish.  I understand the intent (very good commit message) and "more
> or less" how it is done.  Important words on the previous sentence are
> "more or less".  O:-)

Tests pass, so what could possibly go wrong (famous last words).

Thanks!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]