qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 16/16] qemu-file: Make qemu_fflush() return errors


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 16/16] qemu-file: Make qemu_fflush() return errors
Date: Tue, 30 May 2023 14:41:23 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 30/5/23 14:28, Juan Quintela wrote:
This let us simplify code of this shape.

    qemu_fflush(f);
    int ret = qemu_file_get_error(f);
    if (ret) {
       return ret;
    }

into:

    int ret = qemu_fflush(f);
    if (ret) {
       return ret;
    }

I updated all callers where there is any error check.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
  migration/qemu-file.h |  2 +-
  migration/colo.c      | 11 +++--------
  migration/migration.c |  7 +------
  migration/qemu-file.c |  7 ++++---
  migration/ram.c       | 22 +++++++---------------
  migration/rdma.c      |  4 +---
  migration/savevm.c    |  3 +--
  7 files changed, 18 insertions(+), 38 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]