[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/21] block: Take AioContext lock for bdrv_append() more con
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH 04/21] block: Take AioContext lock for bdrv_append() more consistently |
Date: |
Tue, 22 Aug 2023 14:49:20 -0400 |
On Thu, Aug 17, 2023 at 02:50:03PM +0200, Kevin Wolf wrote:
> diff --git a/tests/unit/test-block-iothread.c
> b/tests/unit/test-block-iothread.c
> index d727a5fee8..9155547313 100644
> --- a/tests/unit/test-block-iothread.c
> +++ b/tests/unit/test-block-iothread.c
> @@ -756,11 +756,14 @@ static void test_propagate_mirror(void)
> &error_abort);
>
> /* Start a mirror job */
> + aio_context_acquire(main_ctx);
> mirror_start("job0", src, target, NULL, JOB_DEFAULT, 0, 0, 0,
> MIRROR_SYNC_MODE_NONE, MIRROR_OPEN_BACKING_CHAIN, false,
> BLOCKDEV_ON_ERROR_REPORT, BLOCKDEV_ON_ERROR_REPORT,
> false, "filter_node", MIRROR_COPY_MODE_BACKGROUND,
> &error_abort);
> + aio_context_release(main_ctx);
For other reviewers: mirror_start() isn't mentioned in the commit
description, but it calls bdrv_append() internally.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature
- Re: [PATCH 01/21] block: Remove unused BlockReopenQueueEntry.perms_checked, (continued)
- [PATCH 03/21] preallocate: Don't poll during permission updates, Kevin Wolf, 2023/08/17
- [PATCH 11/21] block: Call transaction callbacks with lock held, Kevin Wolf, 2023/08/17
- [PATCH 04/21] block: Take AioContext lock for bdrv_append() more consistently, Kevin Wolf, 2023/08/17
- [PATCH 08/21] block: Mark bdrv_replace_child_noperm() GRAPH_WRLOCK, Kevin Wolf, 2023/08/17
- [PATCH 06/21] block-coroutine-wrapper: Add no_co_wrapper_bdrv_wrlock functions, Kevin Wolf, 2023/08/17
- [PATCH 19/21] block: Mark bdrv_root_unref_child() GRAPH_WRLOCK, Kevin Wolf, 2023/08/17
- [PATCH 05/21] block: Introduce bdrv_schedule_unref(), Kevin Wolf, 2023/08/17