[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/7] migration: Clean up local variable shadowing
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH 2/7] migration: Clean up local variable shadowing |
|
Date: |
Thu, 31 Aug 2023 16:19:58 -0400 |
On Thu, Aug 31, 2023 at 03:25:41PM +0200, Markus Armbruster wrote:
> Local variables shadowing other local variables or parameters make the
> code needlessly hard to understand. Tracked down with -Wshadow=local.
> Clean up: delete inner declarations when they are actually redundant,
> else rename variables.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
- Re: [PATCH 1/7] migration/rdma: Fix save_page method to fail on polling error, (continued)