Re: [PULL 4/5] hw/ufs: Support for UFS logical unit

[Paolo Bonzini]

On 9/7/23 20:16, Stefan Hajnoczi wrote:
> From: Jeuk Kim<jeuk20.kim@samsung.com>
>
> This commit adds support for ufs logical unit.
> The LU handles processing for the SCSI command,
> unit descriptor query request.
>
> This commit enables the UFS device to process
> IO requests.
>
> Signed-off-by: Jeuk Kim<jeuk20.kim@samsung.com>
> Reviewed-by: Stefan Hajnoczi<stefanha@redhat.com>
> Message-id:beacc504376ab6a14b1a3830bb3c69382cf6aebc.1693980783.git.jeuk20.kim@gmail.com
> Signed-off-by: Stefan Hajnoczi<stefanha@redhat.com>
> ---

Jeuk,

can you explain the differences between scsi-hd and ufs-lu, apart from 
the different bus type?  Ideally, the UFS controller would be in 
hw/scsi/ufs.c and there would be no need for ufs-lu at all.

Would it make sense to allow any SCSI device into a UFS bus without the 
need to have duplicate code?

Thanks!

Paolo