qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/24] block: Mark bdrv_chain_contains() and callers GRAPH_RD


From: Eric Blake
Subject: Re: [PATCH 10/24] block: Mark bdrv_chain_contains() and callers GRAPH_RDLOCK
Date: Fri, 27 Oct 2023 16:17:21 -0500
User-agent: NeoMutt/20231023

On Fri, Oct 27, 2023 at 05:53:19PM +0200, Kevin Wolf wrote:
> This adds GRAPH_RDLOCK annotations to declare that callers of
> bdrv_chain_contains() need to hold a reader lock for the graph because
> it calls bdrv_filter_or_cow_bs(), which accesses bs->file/backing.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  include/block/block-global-state.h |  4 ++-
>  block.c                            |  1 -
>  block/block-copy.c                 |  2 ++
>  blockdev.c                         | 48 +++++++++++++++++-------------
>  4 files changed, 32 insertions(+), 23 deletions(-)
>

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]