qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 06/17] hw/xen: automatically assign device index to block


From: Paul Durrant
Subject: Re: [PATCH v4 06/17] hw/xen: automatically assign device index to block devices
Date: Mon, 6 Nov 2023 15:58:54 +0000
User-agent: Mozilla Thunderbird

On 06/11/2023 14:34, David Woodhouse wrote:
From: David Woodhouse <dwmw@amazon.co.uk>

There's no need to force the user to assign a vdev. We can automatically
assign one, starting at xvda and searching until we find the first disk
name that's unused.

This means we can now allow '-drive if=xen,file=xxx' to work without an
explicit separate -driver argument, just like if=virtio.

Rip out the legacy handling from the xenpv machine, which was scribbling
over any disks configured by the toolstack, and didn't work with anything
but raw images.

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Acked-by: Kevin Wolf <kwolf@redhat.com>
---
  blockdev.c                          |  15 +++-
  hw/block/xen-block.c                | 118 ++++++++++++++++++++++++++--
  hw/xen/xen_devconfig.c              |  28 -------
  hw/xenpv/xen_machine_pv.c           |   9 ---
  include/hw/xen/xen-legacy-backend.h |   1 -
  5 files changed, 125 insertions(+), 46 deletions(-)


Reviewed-by: Paul Durrant <paul@xen.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]