qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC 0/3] aio-posix: call ->poll_end() when removing AioHandler


From: Fiona Ebner
Subject: Re: [RFC 0/3] aio-posix: call ->poll_end() when removing AioHandler
Date: Tue, 19 Dec 2023 09:40:49 +0100
User-agent: Mozilla Thunderbird

Am 18.12.23 um 15:49 schrieb Paolo Bonzini:
> On Mon, Dec 18, 2023 at 1:41 PM Fiona Ebner <f.ebner@proxmox.com> wrote:
>> I think it's because of nested drains, because when additionally
>> checking that the drain count is zero and only executing the loop then,
>> that issue doesn't seem to manifest
> 
> But isn't virtio_scsi_drained_end only run if bus->drain_count == 0?
> 
>     if (bus->drain_count-- == 1) {
>         trace_scsi_bus_drained_end(bus, sdev);
>         if (bus->info->drained_end) {
>             bus->info->drained_end(bus);
>         }
>     }
> 

You're right. Sorry, I must've messed up my testing yesterday :(
Sometimes the CPU spikes are very short-lived. Now I see the same issue
with both variants.

Unfortunately, I haven't been able to figure out why it happens yet.

Best Regards,
Fiona




reply via email to

[Prev in Thread] Current Thread [Next in Thread]