|
From: | maobibo |
Subject: | Re: [PATCH] tests/cdrom-test: Add cdrom test for LoongArch virt machine |
Date: | Mon, 5 Feb 2024 16:13:04 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 2024/2/5 下午3:47, Thomas Huth wrote:
With the latest code, cdrom testcase passes to run. It is strange that about two weeks ago, the result displays SKIP, so I post this patch -:)On 05/02/2024 03.13, Bibo Mao wrote:The cdrom test skips to execute on LoongArch system with command "make check"Are you sure the test is marked with "skip"? ... it should at least test with the "none" machine...?
Regards Bibo Mao
this patch enables cdrom test for LoongArch virt machine platform. With this patch, cdrom test passes to run on LoongArch virt machine type. Signed-off-by: Bibo Mao <maobibo@loongson.cn> --- tests/qtest/cdrom-test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qtest/cdrom-test.c b/tests/qtest/cdrom-test.c index 0945383789..c8b97d8d9a 100644 --- a/tests/qtest/cdrom-test.c +++ b/tests/qtest/cdrom-test.c @@ -271,6 +271,9 @@ int main(int argc, char **argv) const char *virtmachine[] = { "virt", NULL }; add_cdrom_param_tests(virtmachine); } + } else if (g_str_equal(arch, "loongarch64")) { + const char *virtmachine[] = { "virt", NULL }; + add_cdrom_param_tests(virtmachine); } else { const char *nonemachine[] = { "none", NULL }; add_cdrom_param_tests(nonemachine);Anyway, using the virt machine is certainly better than the "none" machine, so:Acked-by: Thomas Huth <thuth@redhat.com>
[Prev in Thread] | Current Thread | [Next in Thread] |