[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 26/28] qemu-img: implement short --help, remove global help()
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 26/28] qemu-img: implement short --help, remove global help() function |
Date: |
Mon, 26 Feb 2024 14:53:33 +0000 |
User-agent: |
Mutt/2.2.12 (2023-09-09) |
On Thu, Feb 22, 2024 at 12:16:07AM +0300, Michael Tokarev wrote:
> now once all individual subcommands has --help support, remove
> the large unreadable help() thing and replace it with small
> global --help, which refers to individual command --help for
> more info.
>
> While at it, also line-wrap list of formats after 75 chars.
>
> Since missing_argument() and unrecognized_option() are now unused,
> remove them.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> qemu-img.c | 172 ++++++++++++-----------------------------------------
> 1 file changed, 39 insertions(+), 133 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 20/28] qemu-img: resize: refresh options/--help, (continued)
- [PATCH 20/28] qemu-img: resize: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 18/28] qemu-img: rebase: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 21/28] qemu-img: amend: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 22/28] qemu-img: bench: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 23/28] qemu-img: bitmap: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 24/28] qemu-img: dd: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 25/28] qemu-img: measure: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 27/28] qemu-img: inline list of supported commands, remove qemu-img-cmds.h include, Michael Tokarev, 2024/02/21
- [PATCH 26/28] qemu-img: implement short --help, remove global help() function, Michael Tokarev, 2024/02/21
- Re: [PATCH 26/28] qemu-img: implement short --help, remove global help() function,
Daniel P . Berrangé <=
- [PATCH 28/28] qemu-img: extend cvtnum() and use it in more places, Michael Tokarev, 2024/02/21