qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 446cfb: fp-bench: fix update_random_ops


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 446cfb: fp-bench: fix update_random_ops
Date: Thu, 24 Jan 2019 05:27:18 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 446cfb0d3487a630ab52efe35977dec24a6db384
      
https://github.com/qemu/qemu/commit/446cfb0d3487a630ab52efe35977dec24a6db384
  Author: Emilio G. Cota <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M tests/fp/fp-bench.c

  Log Message:
  -----------
  fp-bench: fix update_random_ops

The second test in the branches is wrong; fix while converting
to a switch statement, which is easier to get right.

Signed-off-by: Emilio G. Cota <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 392a8adc41ccf182ad0ecf83ab44137a556e6e87
      
https://github.com/qemu/qemu/commit/392a8adc41ccf182ad0ecf83ab44137a556e6e87
  Author: Emilio G. Cota <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M tests/fp/fp-bench.c

  Log Message:
  -----------
  fp-bench: remove wrong exponent raise in fill_random

At this point random_ops[] only contains normals, so there's
no need to do anything to them. In fact, raising the exponent
here can make the output !normal, which is precisely
what the comment says we want to avoid.

Signed-off-by: Emilio G. Cota <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 8b148365eeb650e3a6b024ba367c6a356942b173
      
https://github.com/qemu/qemu/commit/8b148365eeb650e3a6b024ba367c6a356942b173
  Author: Emilio G. Cota <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M tests/fp/berkeley-testfloat-3

  Log Message:
  -----------
  berkeley-testfloat-3: pull changes

- fail: constify fail_programName

Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 2cb0dac60acfb447f436327a96e505fa8e2eb326
      
https://github.com/qemu/qemu/commit/2cb0dac60acfb447f436327a96e505fa8e2eb326
  Author: Emilio G. Cota <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M tests/fp/Makefile

  Log Message:
  -----------
  tests/fp/Makefile: do not use gcc-only -W flags

The build now completes in both gcc and clang.

Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 710fbcd2b2b11ae1f8f82ae48cadcaefd4cf48b2
      
https://github.com/qemu/qemu/commit/710fbcd2b2b11ae1f8f82ae48cadcaefd4cf48b2
  Author: Emilio G. Cota <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M tests/fp/fp-test.c

  Log Message:
  -----------
  fp-test: fix signature of slow_clear_flags and qemu_clear_flags

To match the type in testfloat.

Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: b343eb462bcf825d60a29269054d54aff95b1722
      
https://github.com/qemu/qemu/commit/b343eb462bcf825d60a29269054d54aff95b1722
  Author: Emilio G. Cota <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M tests/fp/platform.h

  Log Message:
  -----------
  tests/fp/platform.h: include config-host.h

We get HOST_WORDS_BIGENDIAN from config-host.h, but the include
is missing. Fix it.

This fixes `make check-softfloat' on big endian hosts.

Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: f6b3b108a808fe07f8a45f82bc88196f668cf627
      
https://github.com/qemu/qemu/commit/f6b3b108a808fe07f8a45f82bc88196f668cf627
  Author: Emilio G. Cota <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M fpu/softfloat.c

  Log Message:
  -----------
  softfloat: enforce softfloat if the host's FMA is broken

The added branch to the FMA ops is marked as unlikely and therefore
its impact on performance (measured with fp-bench) is within noise range
when measured on an Intel(R) Xeon(R) Gold 6142 CPU @ 2.60GHz.

Reported-by: Laurent Desnogues <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 2c00542c70b9cbd6da510c97cd3d46adcf9e3efc
      
https://github.com/qemu/qemu/commit/2c00542c70b9cbd6da510c97cd3d46adcf9e3efc
  Author: Thomas Huth <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M include/fpu/softfloat-macros.h

  Log Message:
  -----------
  include/fpu/softfloat: Fix compilation with Clang on s390x

Clang v7.0.1 does not like the __int128 variable type for inline
assembly on s390x:

In file included from fpu/softfloat.c:97:
include/fpu/softfloat-macros.h:647:9: error: inline asm error:
 This value type register class is not natively supported!
    asm("dlgr %0, %1" : "+r"(n) : "r"(d));
  ^

Disable this code part there now when compiling with Clang, so that
the generic code gets used instead.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Acked-by: Cornelia Huck <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 2cade3d7e542a0be8e2c6c8b1d3b499a9b14cb27
      
https://github.com/qemu/qemu/commit/2cade3d7e542a0be8e2c6c8b1d3b499a9b14cb27
  Author: Alex Bennée <address@hidden>
  Date:   2019-01-23 (Wed, 23 Jan 2019)

  Changed paths:
    M tests/Makefile.include

  Log Message:
  -----------
  tests/Makefile: add floating point tests

Wire up test/fp-test into the main testing Makefile. Currently we skip
some of the extF80 and f128 related tests. Once we re-factor and fix
these tests the plumbing should get simpler.

Signed-off-by: Alex Bennée <address@hidden>


  Commit: 1627a36ead992596612ae4079146a182af82c3af
      
https://github.com/qemu/qemu/commit/1627a36ead992596612ae4079146a182af82c3af
  Author: Alex Bennée <address@hidden>
  Date:   2019-01-23 (Wed, 23 Jan 2019)

  Changed paths:
    M scripts/archive-source.sh

  Log Message:
  -----------
  scripts/archive-source: include softfloat tests

We need these if we want to run unit/softfloat tests in our docker
containers.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>


  Commit: 7617010250822677348af2bd98f048be10e7f334
      
https://github.com/qemu/qemu/commit/7617010250822677348af2bd98f048be10e7f334
  Author: Alex Bennée <address@hidden>
  Date:   2019-01-23 (Wed, 23 Jan 2019)

  Changed paths:
    M tests/Makefile.include

  Log Message:
  -----------
  tests/Makefile: add check-softfloat rule

This adds a rule to run all of our softfloat tests. It is included as
a pre-requisite to check-tcg and check-unit as well.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Emilio G. Cota <address@hidden>


  Commit: 3e821195b16777aeec3641e3b42043dc8952821f
      
https://github.com/qemu/qemu/commit/3e821195b16777aeec3641e3b42043dc8952821f
  Author: Peter Maydell <address@hidden>
  Date:   2019-01-24 (Thu, 24 Jan 2019)

  Changed paths:
    M fpu/softfloat.c
    M include/fpu/softfloat-macros.h
    M scripts/archive-source.sh
    M tests/Makefile.include
    M tests/fp/Makefile
    M tests/fp/berkeley-testfloat-3
    M tests/fp/fp-bench.c
    M tests/fp/fp-test.c
    M tests/fp/platform.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stsquad/tags/pull-fpu-next-230119-2' 
into staging

Some more softfloat/fpu fixes

   - make check-softfloat
   - fixes for fp-bench
   - workaround broken host fma
   - compile fix for s390x/clang
   - fixed for bigendian (v2)
   - minor makefile tweaks (v2)

# gpg: Signature made Wed 23 Jan 2019 11:37:53 GMT
# gpg:                using RSA key FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) <address@hidden>"
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* remotes/stsquad/tags/pull-fpu-next-230119-2:
  tests/Makefile: add check-softfloat rule
  scripts/archive-source: include softfloat tests
  tests/Makefile: add floating point tests
  include/fpu/softfloat: Fix compilation with Clang on s390x
  softfloat: enforce softfloat if the host's FMA is broken
  tests/fp/platform.h: include config-host.h
  fp-test: fix signature of slow_clear_flags and qemu_clear_flags
  tests/fp/Makefile: do not use gcc-only -W flags
  berkeley-testfloat-3: pull changes
  fp-bench: remove wrong exponent raise in fill_random
  fp-bench: fix update_random_ops

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/6d809e7da943...3e821195b167
      **NOTE:** GitHub Services has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      We will provide an alternative path for the email notifications by 
January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]