qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] b748c6: tcg/aarch64: Apple does not align __i


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] b748c6: tcg/aarch64: Apple does not align __int128_t in ev...
Date: Fri, 23 Feb 2024 01:51:23 -0800

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: b748c6eafa0033ef0415dfb220d19cee7029c682
      
https://github.com/qemu/qemu/commit/b748c6eafa0033ef0415dfb220d19cee7029c682
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M tcg/aarch64/tcg-target.h

  Log Message:
  -----------
  tcg/aarch64: Apple does not align __int128_t in even registers

>From 
>https://developer.apple.com/documentation/xcode/writing-arm64-code-for-apple-platforms

  When passing an argument with 16-byte alignment in integer registers,
  Apple platforms allow the argument to start in an odd-numbered xN
  register. The standard ABI requires it to begin in an even-numbered
  xN register.

Cc: qemu-stable@nongnu.org
Fixes: 5427a9a7604 ("tcg: Add TCG_TARGET_CALL_{RET,ARG}_I128")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2169
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <9fc0c2c7-dd57-459e-aecb-528edb74b4a7@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: 4f49027eb0fcf8882938999d474e7bb99d8d40ec
      
https://github.com/qemu/qemu/commit/4f49027eb0fcf8882938999d474e7bb99d8d40ec
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M accel/tcg/cpu-exec.c

  Log Message:
  -----------
  accel/tcg: Set can_do_io at at start of lookup_tb_ptr helper

If a page table is in IO memory and lookup_tb_ptr probes
the TLB it can result in a page table walk for the instruction
fetch.  If this hits IO memory and io_prepare falsely assumes
it needs to do a TLB recompile.

Avoid that by setting can_do_io at the start of lookup_tb_ptr.

Link: 
https://lore.kernel.org/qemu-devel/CAFEAcA_a_AyQ=Epz3_+CheAT8Crsk9mOu894wbNW_FywamkZiw@mail.gmail.com/#t

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20240219173153.12114-2-Jonathan.Cameron@huawei.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 9b5793b4d939702fe2eb734eeb88dba1fc22c19b
      
https://github.com/qemu/qemu/commit/9b5793b4d939702fe2eb734eeb88dba1fc22c19b
  Author: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M accel/tcg/cputlb.c

  Log Message:
  -----------
  tcg: Avoid double lock if page tables happen to be in mmio memory.

On i386, after fixing the page walking code to work with pages in
MMIO memory (specifically CXL emulated interleaved memory),
a crash was seen in an interrupt handling path.

Useful part of backtrace

7  0x0000555555ab1929 in bql_lock_impl (file=0x555556049122 
"../../accel/tcg/cputlb.c", line=2033) at ../../system/cpus.c:524
8  bql_lock_impl (file=file@entry=0x555556049122 "../../accel/tcg/cputlb.c", 
line=line@entry=2033) at ../../system/cpus.c:520
9  0x0000555555c9f7d6 in do_ld_mmio_beN (cpu=0x5555578e0cb0, 
full=0x7ffe88012950, ret_be=ret_be@entry=0, addr=19595792376, 
size=size@entry=8, mmu_idx=4, type=MMU_DATA_LOAD, ra=0) at 
../../accel/tcg/cputlb.c:2033
10 0x0000555555ca0fbd in do_ld_8 (cpu=cpu@entry=0x5555578e0cb0, 
p=p@entry=0x7ffff4efd1d0, mmu_idx=<optimized out>, 
type=type@entry=MMU_DATA_LOAD, memop=<optimized out>, ra=ra@entry=0) at 
../../accel/tcg/cputlb.c:2356
11 0x0000555555ca341f in do_ld8_mmu (cpu=cpu@entry=0x5555578e0cb0, 
addr=addr@entry=19595792376, oi=oi@entry=52, ra=0, ra@entry=52, 
access_type=access_type@entry=MMU_DATA_LOAD) at ../../accel/tcg/cputlb.c:2439
12 0x0000555555ca5f59 in cpu_ldq_mmu (ra=52, oi=52, addr=19595792376, 
env=0x5555578e3470) at ../../accel/tcg/ldst_common.c.inc:169
13 cpu_ldq_le_mmuidx_ra (env=0x5555578e3470, addr=19595792376, 
mmu_idx=<optimized out>, ra=ra@entry=0) at ../../accel/tcg/ldst_common.c.inc:301
14 0x0000555555b4b5fc in ptw_ldq (ra=0, in=0x7ffff4efd320) at 
../../target/i386/tcg/sysemu/excp_helper.c:98
15 ptw_ldq (ra=0, in=0x7ffff4efd320) at 
../../target/i386/tcg/sysemu/excp_helper.c:93
16 mmu_translate (env=env@entry=0x5555578e3470, in=0x7ffff4efd3e0, 
out=0x7ffff4efd3b0, err=err@entry=0x7ffff4efd3c0, ra=ra@entry=0) at 
../../target/i386/tcg/sysemu/excp_helper.c:174
17 0x0000555555b4c4b3 in get_physical_address (ra=0, err=0x7ffff4efd3c0, 
out=0x7ffff4efd3b0, mmu_idx=0, access_type=MMU_DATA_LOAD, 
addr=18446741874686299840, env=0x5555578e3470) at 
../../target/i386/tcg/sysemu/excp_helper.c:580
18 x86_cpu_tlb_fill (cs=0x5555578e0cb0, addr=18446741874686299840, 
size=<optimized out>, access_type=MMU_DATA_LOAD, mmu_idx=0, probe=<optimized 
out>, retaddr=0) at ../../target/i386/tcg/sysemu/excp_helper.c:606
19 0x0000555555ca0ee9 in tlb_fill (retaddr=0, mmu_idx=0, 
access_type=MMU_DATA_LOAD, size=<optimized out>, addr=18446741874686299840, 
cpu=0x7ffff4efd540) at ../../accel/tcg/cputlb.c:1315
20 mmu_lookup1 (cpu=cpu@entry=0x5555578e0cb0, data=data@entry=0x7ffff4efd540, 
mmu_idx=0, access_type=access_type@entry=MMU_DATA_LOAD, ra=ra@entry=0) at 
../../accel/tcg/cputlb.c:1713
21 0x0000555555ca2c61 in mmu_lookup (cpu=cpu@entry=0x5555578e0cb0, 
addr=addr@entry=18446741874686299840, oi=oi@entry=32, ra=ra@entry=0, 
type=type@entry=MMU_DATA_LOAD, l=l@entry=0x7ffff4efd540) at 
../../accel/tcg/cputlb.c:1803
22 0x0000555555ca3165 in do_ld4_mmu (cpu=cpu@entry=0x5555578e0cb0, 
addr=addr@entry=18446741874686299840, oi=oi@entry=32, ra=ra@entry=0, 
access_type=access_type@entry=MMU_DATA_LOAD) at ../../accel/tcg/cputlb.c:2416
23 0x0000555555ca5ef9 in cpu_ldl_mmu (ra=0, oi=32, addr=18446741874686299840, 
env=0x5555578e3470) at ../../accel/tcg/ldst_common.c.inc:158
24 cpu_ldl_le_mmuidx_ra (env=env@entry=0x5555578e3470, 
addr=addr@entry=18446741874686299840, mmu_idx=<optimized out>, ra=ra@entry=0) 
at ../../accel/tcg/ldst_common.c.inc:294
25 0x0000555555bb6cdd in do_interrupt64 (is_hw=1, 
next_eip=18446744072399775809, error_code=0, is_int=0, intno=236, 
env=0x5555578e3470) at ../../target/i386/tcg/seg_helper.c:889
26 do_interrupt_all (cpu=cpu@entry=0x5555578e0cb0, intno=236, 
is_int=is_int@entry=0, error_code=error_code@entry=0, 
next_eip=next_eip@entry=0, is_hw=is_hw@entry=1) at 
../../target/i386/tcg/seg_helper.c:1130
27 0x0000555555bb87da in do_interrupt_x86_hardirq 
(env=env@entry=0x5555578e3470, intno=<optimized out>, is_hw=is_hw@entry=1) at 
../../target/i386/tcg/seg_helper.c:1162
28 0x0000555555b5039c in x86_cpu_exec_interrupt (cs=0x5555578e0cb0, 
interrupt_request=<optimized out>) at 
../../target/i386/tcg/sysemu/seg_helper.c:197
29 0x0000555555c94480 in cpu_handle_interrupt (last_tb=<synthetic pointer>, 
cpu=0x5555578e0cb0) at ../../accel/tcg/cpu-exec.c:844

Peter identified this as being due to the BQL already being
held when the page table walker encounters MMIO memory and attempts
to take the lock again.  There are other examples of similar paths
TCG, so this follows the approach taken in those of simply checking
if the lock is already held and if it is, don't take it again.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20240219173153.12114-4-Jonathan.Cameron@huawei.com>
[rth: Use BQL_LOCK_GUARD]
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 869c0a86ee7af735d633b747a9a8816836337e68
      
https://github.com/qemu/qemu/commit/869c0a86ee7af735d633b747a9a8816836337e68
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M accel/tcg/user-exec.c

  Log Message:
  -----------
  accel/tcg: Remove qemu_host_page_size from page_protect/page_unprotect

Use qemu_real_host_page_size instead.  Except for the final mprotect
within page_protect, we already handled host < target page size.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-2-richard.henderson@linaro.org>


  Commit: e32b3d7c2ef65b3ab1ea87521f39d936a2607b03
      
https://github.com/qemu/qemu/commit/e32b3d7c2ef65b3ab1ea87521f39d936a2607b03
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user: Adjust SVr4 NULL page mapping

Use TARGET_PAGE_SIZE and MAP_FIXED_NOREPLACE.

We really should be attending to this earlier during
probe_guest_base, as well as better detection and
emulation of various Linux personalities.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-3-richard.henderson@linaro.org>


  Commit: 37398cd2f1b5d993cae2eaeb75f0bd6628ff6e24
      
https://github.com/qemu/qemu/commit/37398cd2f1b5d993cae2eaeb75f0bd6628ff6e24
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user: Remove qemu_host_page_{size, mask} in probe_guest_base

The host SHMLBA is by definition a multiple of the host page size.
Thus the remaining component of qemu_host_page_size is the
target page size.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-4-richard.henderson@linaro.org>


  Commit: 3bd3be36c04bacfc9491af541257a2c8e49e8c6a
      
https://github.com/qemu/qemu/commit/3bd3be36c04bacfc9491af541257a2c8e49e8c6a
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user: Remove qemu_host_page_size from create_elf_tables

AT_PAGESZ is supposed to advertise the guest page size.
The random adjustment made here using qemu_host_page_size
does not match anything else within linux-user.

The idea here is good, but should be done more systemically
via adjustment to TARGET_PAGE_SIZE.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-5-richard.henderson@linaro.org>


  Commit: 506416d7230eefd26294aa747d55d65e7efb32ba
      
https://github.com/qemu/qemu/commit/506416d7230eefd26294aa747d55d65e7efb32ba
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user/hppa: Simplify init_guest_commpage

If reserved_va, then we have already reserved the entire
guest virtual address space; no need to remap page.
If !reserved_va, then use MAP_FIXED_NOREPLACE.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-6-richard.henderson@linaro.org>


  Commit: 228a425bb630dfb51e9ed2684c5aa0cd7439a068
      
https://github.com/qemu/qemu/commit/228a425bb630dfb51e9ed2684c5aa0cd7439a068
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user/nios2: Remove qemu_host_page_size from init_guest_commpage

Use qemu_real_host_page_size.
If !reserved_va, use MAP_FIXED_NOREPLACE.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-7-richard.henderson@linaro.org>


  Commit: 0124231030db19ee8fee2beedb508c9780522107
      
https://github.com/qemu/qemu/commit/0124231030db19ee8fee2beedb508c9780522107
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user/arm: Remove qemu_host_page_size from init_guest_commpage

Use qemu_real_host_page_size.
If the commpage is not within reserved_va, use MAP_FIXED_NOREPLACE.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-8-richard.henderson@linaro.org>


  Commit: f0e18f54bd3b008260bc20d12b104ddaa9174313
      
https://github.com/qemu/qemu/commit/f0e18f54bd3b008260bc20d12b104ddaa9174313
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/mmap.c

  Log Message:
  -----------
  linux-user: Remove qemu_host_page_{size, mask} from mmap.c

Use qemu_real_host_page_size instead.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-9-richard.henderson@linaro.org>


  Commit: d8abdc8baf0e74560c3de105893962dd177b6c99
      
https://github.com/qemu/qemu/commit/d8abdc8baf0e74560c3de105893962dd177b6c99
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/mmap.c

  Log Message:
  -----------
  linux-user: Remove REAL_HOST_PAGE_ALIGN from mmap.c

We already have qemu_real_host_page_size() in a local variable.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-10-richard.henderson@linaro.org>


  Commit: 8a1ba5ba5ab7aca70495f338c9e937c133487445
      
https://github.com/qemu/qemu/commit/8a1ba5ba5ab7aca70495f338c9e937c133487445
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/mmap.c

  Log Message:
  -----------
  linux-user: Remove HOST_PAGE_ALIGN from mmap.c

This removes a hidden use of qemu_host_page_size, using instead
the existing host_page_size local within each function.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-11-richard.henderson@linaro.org>


  Commit: 7cdaef1958be7db1f13f4b1c9f446961fd06322b
      
https://github.com/qemu/qemu/commit/7cdaef1958be7db1f13f4b1c9f446961fd06322b
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  migration: Remove qemu_host_page_size

Replace with the maximum of the real host page size
and the target page size.  This is an exact replacement.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-12-richard.henderson@linaro.org>


  Commit: 9f9fe60c9cab68971ecb9d11fef7d678a2d14aae
      
https://github.com/qemu/qemu/commit/9f9fe60c9cab68971ecb9d11fef7d678a2d14aae
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M hw/tpm/tpm_ppi.c

  Log Message:
  -----------
  hw/tpm: Remove HOST_PAGE_ALIGN from tpm_ppi_init

This removes a hidden use of qemu_host_page_size, hoisting
two uses of qemu_real_host_page_size to a local variable.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>


  Commit: 9ecacd2495a3a5dc700e66445255137d51116b24
      
https://github.com/qemu/qemu/commit/9ecacd2495a3a5dc700e66445255137d51116b24
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M system/physmem.c

  Log Message:
  -----------
  softmmu/physmem: Remove qemu_host_page_size

Use qemu_real_host_page_size() instead.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-14-richard.henderson@linaro.org>


  Commit: 724051357c7722a4b9d0e6be699a0797bc2806f0
      
https://github.com/qemu/qemu/commit/724051357c7722a4b9d0e6be699a0797bc2806f0
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M system/physmem.c

  Log Message:
  -----------
  softmmu/physmem: Remove HOST_PAGE_ALIGN

Align allocation sizes to the maximum of host and target page sizes.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-15-richard.henderson@linaro.org>


  Commit: 40767bbf9ab84682b7543ec944e1026c7bccead5
      
https://github.com/qemu/qemu/commit/40767bbf9ab84682b7543ec944e1026c7bccead5
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/main.c

  Log Message:
  -----------
  linux-user: Remove qemu_host_page_size from main

Use qemu_real_host_page_size() instead.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-16-richard.henderson@linaro.org>


  Commit: cd005831f840d33e61a115dd12b1101e640937d6
      
https://github.com/qemu/qemu/commit/cd005831f840d33e61a115dd12b1101e640937d6
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/mmap.c

  Log Message:
  -----------
  linux-user: Split out target_mmap__locked

All "goto fail" may be transformed to "return -1".

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-17-richard.henderson@linaro.org>


  Commit: 264360a514a1b0544d4373dd7c3f3679b04b1bfe
      
https://github.com/qemu/qemu/commit/264360a514a1b0544d4373dd7c3f3679b04b1bfe
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/mmap.c

  Log Message:
  -----------
  linux-user: Move some mmap checks outside the lock

Basic validation of operands does not require the lock.
Hoist them from target_mmap__locked back into target_mmap.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-18-richard.henderson@linaro.org>


  Commit: 97ca02e05c841aee2c105cc3e93a899114cfbef1
      
https://github.com/qemu/qemu/commit/97ca02e05c841aee2c105cc3e93a899114cfbef1
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/mmap.c

  Log Message:
  -----------
  linux-user: Fix sub-host-page mmap

We cannot skip over the_end1 to the_end, because we fail to
record the validity of the guest page with the interval tree.
Remove "the_end" and rename "the_end1" to "the_end".

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-19-richard.henderson@linaro.org>


  Commit: e09767ed34829ef78403adb58639cd38d4e6522c
      
https://github.com/qemu/qemu/commit/e09767ed34829ef78403adb58639cd38d4e6522c
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/mmap.c

  Log Message:
  -----------
  linux-user: Split out mmap_end

Use a subroutine instead of a goto within target_mmap__locked.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-20-richard.henderson@linaro.org>


  Commit: 152480f99ebedc7bf04bd2020a1e82ee1eb19189
      
https://github.com/qemu/qemu/commit/152480f99ebedc7bf04bd2020a1e82ee1eb19189
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/mmap.c

  Log Message:
  -----------
  linux-user: Do early mmap placement only for reserved_va

For reserved_va, place all non-fixed maps then proceed
as for MAP_FIXED.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-21-richard.henderson@linaro.org>


  Commit: e1b8b75fd9bbe86045050a129ad1a564e37ea6b0
      
https://github.com/qemu/qemu/commit/e1b8b75fd9bbe86045050a129ad1a564e37ea6b0
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/mmap.c

  Log Message:
  -----------
  linux-user: Split out do_munmap

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 05c4a8ac3eaa52ee93541d1e38abab465f133366
      
https://github.com/qemu/qemu/commit/05c4a8ac3eaa52ee93541d1e38abab465f133366
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/mmap.c

  Log Message:
  -----------
  linux-user: Use do_munmap for target_mmap failure

For the cases for which the host mmap succeeds, but does
not yield the desired address, use do_munmap to restore
the reserved_va memory reservation.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 97f3e1965c41756f28500f6182d0bcc71b6b0cb7
      
https://github.com/qemu/qemu/commit/97f3e1965c41756f28500f6182d0bcc71b6b0cb7
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/mmap.c

  Log Message:
  -----------
  linux-user: Split out mmap_h_eq_g

Move the MAX_FIXED_NOREPLACE check for reserved_va earlier.
Move the computation of host_prot earlier.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-22-richard.henderson@linaro.org>


  Commit: 56fb067efd5b65736f395f066e86334ea51d46bb
      
https://github.com/qemu/qemu/commit/56fb067efd5b65736f395f066e86334ea51d46bb
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/mmap.c

  Log Message:
  -----------
  linux-user: Split out mmap_h_lt_g

Work much harder to get alignment and mapping beyond the end
of the file correct.  Both of which are excercised by our
test-mmap for alpha (8k pages) on any 4k page host.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-23-richard.henderson@linaro.org>


  Commit: e50818983891c0044d046b6ee4537244094fceb5
      
https://github.com/qemu/qemu/commit/e50818983891c0044d046b6ee4537244094fceb5
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/mmap.c

  Log Message:
  -----------
  linux-user: Split out mmap_h_gt_g

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-24-richard.henderson@linaro.org>


  Commit: be63ed40989b815d7b86bd453caca82dc4872d0c
      
https://github.com/qemu/qemu/commit/be63ed40989b815d7b86bd453caca82dc4872d0c
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M tests/tcg/alpha/Makefile.target
    M tests/tcg/arm/Makefile.target
    M tests/tcg/hppa/Makefile.target
    M tests/tcg/i386/Makefile.target
    M tests/tcg/m68k/Makefile.target
    M tests/tcg/multiarch/Makefile.target
    R tests/tcg/ppc/Makefile.target
    M tests/tcg/sh4/Makefile.target
    R tests/tcg/sparc64/Makefile.target

  Log Message:
  -----------
  tests/tcg: Remove run-test-mmap-*

These tests are confused, because -p does not change
the guest page size, but the host page size.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-25-richard.henderson@linaro.org>


  Commit: 2bb2a217c264c33cbcdb60ba83889954591b4695
      
https://github.com/qemu/qemu/commit/2bb2a217c264c33cbcdb60ba83889954591b4695
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M tests/tcg/multiarch/linux/linux-madvise.c

  Log Message:
  -----------
  tests/tcg: Extend file in linux-madvise.c

When guest page size > host page size, this test can fail
due to the SIGBUS protection hack.  Avoid this by making
sure that the file size is at least one guest page.

Visible with alpha guest on x86_64 host.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-26-richard.henderson@linaro.org>


  Commit: 1b65fc5e0580243e60f6269ac3a47b9ee04be93e
      
https://github.com/qemu/qemu/commit/1b65fc5e0580243e60f6269ac3a47b9ee04be93e
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M bsd-user/main.c
    M docs/about/deprecated.rst
    M docs/user/main.rst
    M linux-user/main.c

  Log Message:
  -----------
  *-user: Deprecate and disable -p pagesize

This option controls the host page size.  From the mis-usage in
our own testsuite, this is easily confused with guest page size.

The only thing that occurs when changing the host page size is
that stuff breaks, because one cannot actually change the host
page size.  Therefore reject all but the no-op setting as part
of the deprecation process.

Reviewed-by: Warner Losh <imp@bsdimp.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-27-richard.henderson@linaro.org>


  Commit: 490b288f01c5b8323eccd3342e723b58f7fc5657
      
https://github.com/qemu/qemu/commit/490b288f01c5b8323eccd3342e723b58f7fc5657
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M accel/tcg/translate-all.c
    M bsd-user/main.c
    M bsd-user/qemu.h
    M cpu-target.c
    M include/exec/cpu-common.h
    M include/hw/core/cpu.h
    M system/vl.c

  Log Message:
  -----------
  cpu: Remove page_size_init

Move qemu_host_page_{size,mask} and HOST_PAGE_ALIGN into bsd-user.
It should be removed from bsd-user as well, but defer that cleanup.

Reviewed-by: Warner Losh <imp@bsdimp.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-28-richard.henderson@linaro.org>


  Commit: 8c0118a75bb44d3146ebb8e691ce0dbe3b6e9d03
      
https://github.com/qemu/qemu/commit/8c0118a75bb44d3146ebb8e691ce0dbe3b6e9d03
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M accel/tcg/user-exec.c

  Log Message:
  -----------
  accel/tcg: Disconnect TargetPageDataNode from page size

Dynamically size the node for the runtime target page size.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-29-richard.henderson@linaro.org>


  Commit: ea5def159e004206fdf7ee59e203d9804bc8a826
      
https://github.com/qemu/qemu/commit/ea5def159e004206fdf7ee59e203d9804bc8a826
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/main.c

  Log Message:
  -----------
  linux-user: Allow TARGET_PAGE_BITS_VARY

If set, match the host and guest page sizes.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-30-richard.henderson@linaro.org>


  Commit: 46102f982b2fdbc3ad9fd8c0c2d2bd21e1998ebc
      
https://github.com/qemu/qemu/commit/46102f982b2fdbc3ad9fd8c0c2d2bd21e1998ebc
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M target/arm/cpu-param.h
    M target/arm/cpu.c

  Log Message:
  -----------
  target/arm: Enable TARGET_PAGE_BITS_VARY for AArch64 user-only

Since aarch64 binaries are generally built for multiple
page sizes, it is trivial to allow the page size to vary.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-31-richard.henderson@linaro.org>


  Commit: 714e41bc3eba3d7b17789ac5a47f0f8881afcc4f
      
https://github.com/qemu/qemu/commit/714e41bc3eba3d7b17789ac5a47f0f8881afcc4f
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/main.c

  Log Message:
  -----------
  linux-user: Bound mmap_min_addr by host page size

Bizzarely, it is possible to set /proc/sys/vm/mmap_min_addr
to a value below the host page size.  Fix that.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-32-richard.henderson@linaro.org>


  Commit: 242112f4cc7c9dbe4bbfc78cc3b435d686aa0fea
      
https://github.com/qemu/qemu/commit/242112f4cc7c9dbe4bbfc78cc3b435d686aa0fea
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M target/ppc/cpu-param.h

  Log Message:
  -----------
  target/ppc: Enable TARGET_PAGE_BITS_VARY for user-only

Since ppc binaries are generally built for multiple
page sizes, it is trivial to allow the page size to vary.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-33-richard.henderson@linaro.org>


  Commit: 097171a83daffb46f9c8450c79ea84a21a5b1537
      
https://github.com/qemu/qemu/commit/097171a83daffb46f9c8450c79ea84a21a5b1537
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M target/alpha/cpu-param.h

  Log Message:
  -----------
  target/alpha: Enable TARGET_PAGE_BITS_VARY for user-only

Since alpha binaries are generally built for multiple
page sizes, it is trivial to allow the page size to vary.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-34-richard.henderson@linaro.org>


  Commit: a06efc2615a1283e139e35ae8a8875925766268f
      
https://github.com/qemu/qemu/commit/a06efc2615a1283e139e35ae8a8875925766268f
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user: Remove pgb_dynamic alignment assertion

The assertion was never correct, because the alignment is a composite
of the image alignment and SHMLBA.  Even if the image alignment didn't
match the image address, an assertion would not be correct -- more
appropriate would be an error message about an ill formed image.  But
the image cannot be held to SHMLBA under any circumstances.

Fixes: ee94743034b ("linux-user: completely re-write init_guest_space")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2157
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reported-by: Alexey Sheplyakov <asheplyakov@yandex.ru>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: ffa951df7c7a876982cb112f8656b75c522b5ad9
      
https://github.com/qemu/qemu/commit/ffa951df7c7a876982cb112f8656b75c522b5ad9
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-02-23 (Fri, 23 Feb 2024)

  Changed paths:
    M accel/tcg/cpu-exec.c
    M accel/tcg/cputlb.c
    M accel/tcg/translate-all.c
    M accel/tcg/user-exec.c
    M bsd-user/main.c
    M bsd-user/qemu.h
    M cpu-target.c
    M docs/about/deprecated.rst
    M docs/user/main.rst
    M hw/tpm/tpm_ppi.c
    M include/exec/cpu-common.h
    M include/hw/core/cpu.h
    M linux-user/elfload.c
    M linux-user/main.c
    M linux-user/mmap.c
    M migration/ram.c
    M system/physmem.c
    M system/vl.c
    M target/alpha/cpu-param.h
    M target/arm/cpu-param.h
    M target/arm/cpu.c
    M target/ppc/cpu-param.h
    M tcg/aarch64/tcg-target.h
    M tests/tcg/alpha/Makefile.target
    M tests/tcg/arm/Makefile.target
    M tests/tcg/hppa/Makefile.target
    M tests/tcg/i386/Makefile.target
    M tests/tcg/m68k/Makefile.target
    M tests/tcg/multiarch/Makefile.target
    M tests/tcg/multiarch/linux/linux-madvise.c
    R tests/tcg/ppc/Makefile.target
    M tests/tcg/sh4/Makefile.target
    R tests/tcg/sparc64/Makefile.target

  Log Message:
  -----------
  Merge tag 'pull-tcg-20240222' of https://gitlab.com/rth7680/qemu into staging

tcg/aarch64: Apple does not align __int128_t in even registers
accel/tcg: Fixes for page tables in mmio memory
linux-user: Remove qemu_host_page_{size,mask}, HOST_PAGE_ALIGN
migration: Remove qemu_host_page_size
hw/tpm: Remove qemu_host_page_size
softmmu: Remove qemu_host_page_{size,mask}, HOST_PAGE_ALIGN
linux-user: Split and reorganize target_mmap.
*-user: Deprecate and disable -p pagesize
linux-user: Allow TARGET_PAGE_BITS_VARY
target/alpha: Enable TARGET_PAGE_BITS_VARY for user-only
target/arm: Enable TARGET_PAGE_BITS_VARY for AArch64 user-only
target/ppc: Enable TARGET_PAGE_BITS_VARY for user-only
linux-user: Remove pgb_dynamic alignment assertion

# -----BEGIN PGP SIGNATURE-----
#
# iQFRBAABCgA7FiEEekgeeIaLTbaoWgXAZN846K9+IV8FAmXXsa8dHHJpY2hhcmQu
# aGVuZGVyc29uQGxpbmFyby5vcmcACgkQZN846K9+IV/weAgAhQRJvkTt9vavyCy8
# mq2E11t1gISJlKinaT29wqWL9cI3hm17iekhI4TCg3Pj1SKD5JOsuDFgyoaRKL5M
# KK78r0m0AsWxWlr9y02T7Qo30MDV8C2AWBYMTRJJaCX9L8eYf9s2604SIfKfif+Z
# k3HllEgfmcJ7J9zszv4u21IsT1GPuEG5EW4CzrQTaHsBRlS/LyerKt9SeQ9SXTXp
# UUOEtHiyQ1bLUa0D3QxHGsPWibPrWC7Zmz9RbfmbElXLaSJPVG5HG53DpnWZMK1B
# LX18l9AaRwSmwWzpcQ5kqra9FFbK7Wfc/cyPebBlxEHD62QH5vP79bKT6G+FfqAG
# b6CLTA==
# =XScE
# -----END PGP SIGNATURE-----
# gpg: Signature made Thu 22 Feb 2024 20:42:23 GMT
# gpg:                using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F
# gpg:                issuer "richard.henderson@linaro.org"
# gpg: Good signature from "Richard Henderson <richard.henderson@linaro.org>" 
[full]
# Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A  05C0 64DF 38E8 AF7E 215F

* tag 'pull-tcg-20240222' of https://gitlab.com/rth7680/qemu: (39 commits)
  linux-user: Remove pgb_dynamic alignment assertion
  target/alpha: Enable TARGET_PAGE_BITS_VARY for user-only
  target/ppc: Enable TARGET_PAGE_BITS_VARY for user-only
  linux-user: Bound mmap_min_addr by host page size
  target/arm: Enable TARGET_PAGE_BITS_VARY for AArch64 user-only
  linux-user: Allow TARGET_PAGE_BITS_VARY
  accel/tcg: Disconnect TargetPageDataNode from page size
  cpu: Remove page_size_init
  *-user: Deprecate and disable -p pagesize
  tests/tcg: Extend file in linux-madvise.c
  tests/tcg: Remove run-test-mmap-*
  linux-user: Split out mmap_h_gt_g
  linux-user: Split out mmap_h_lt_g
  linux-user: Split out mmap_h_eq_g
  linux-user: Use do_munmap for target_mmap failure
  linux-user: Split out do_munmap
  linux-user: Do early mmap placement only for reserved_va
  linux-user: Split out mmap_end
  linux-user: Fix sub-host-page mmap
  linux-user: Move some mmap checks outside the lock
  ...

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/3d54cbf269d6...ffa951df7c7a

To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications



reply via email to

[Prev in Thread] Current Thread [Next in Thread]