qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] a9bdc4: target: hppa: Fix unaligned double wo

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] a9bdc4: target: hppa: Fix unaligned double word accesses f...
Date: Mon, 04 Mar 2024 08:02:04 -0800 
  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: a9bdc4c95e402599e4184d4814800668479adb2b
      
https://github.com/qemu/qemu/commit/a9bdc4c95e402599e4184d4814800668479adb2b
  Author: Guenter Roeck <linux@roeck-us.net>
  Date:   2024-03-03 (Sun, 03 Mar 2024)

  Changed paths:
    M target/hppa/helper.c

  Log Message:
  -----------
  target: hppa: Fix unaligned double word accesses for hppa64

Unaligned 64-bit accesses were found in Linux to clobber carry bits,
resulting in bad results if an arithmetic operation involving a
carry bit was executed after an unaligned 64-bit operation.

hppa 2.0 defines additional carry bits in PSW register bits 32..39.
When restoring PSW after executing an unaligned instruction trap, those
bits were not cleared and ended up to be active all the time. Since there
are no bits other than the upper carry bits needed in the upper 32 bit of
env->psw and since those are stored in env->psw_cb, just clear the entire
upper 32 bit when storing psw to solve the problem unconditionally.

Fixes: 931adff31478 ("target/hppa: Update cpu_hppa_get/put_psw for hppa64")
Cc: Richard Henderson <richard.henderson@linaro.org>
Cc: Charlie Jenkins <charlie@rivosinc.com>
Cc: Helge Deller <deller@gmx.de>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Helge Deller <deller@gmx.de>


  Commit: 5ccd50172a80ef9fe695714744b0747d7419b2c4
      
https://github.com/qemu/qemu/commit/5ccd50172a80ef9fe695714744b0747d7419b2c4
  Author: Helge Deller <deller@gmx.de>
  Date:   2024-03-03 (Sun, 03 Mar 2024)

  Changed paths:
    M target/hppa/cpu.c
    M target/hppa/mem_helper.c
    M target/hppa/op_helper.c

  Log Message:
  -----------
  target/hppa: Restore unwind_breg before calculating ior

When calculating the IOR for the exception handlers, the current
unwind_breg value is needed on 64-bit hppa machines.
Restore that value by calling cpu_restore_state() earlier, which in turn
calls hppa_restore_state_to_opc() which restores the unwind_breg for the
current instruction.

Signed-off-by: Helge Deller <deller@gmx.de>
Fixes: 3824e0d643f3 ("target/hppa: Export function hppa_set_ior_and_isr()")
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 19f9c0442ebf28acf96d0e12ab500afbe53c8fa3
      
https://github.com/qemu/qemu/commit/19f9c0442ebf28acf96d0e12ab500afbe53c8fa3
  Author: Helge Deller <deller@gmx.de>
  Date:   2024-03-03 (Sun, 03 Mar 2024)

  Changed paths:
    M pc-bios/meson.build

  Log Message:
  -----------
  pc-bios/meson: Add hppa-firmware64.img blob

Add the missing 64-bit hppa firmware blob so that it gets installed.

Signed-off-by: Helge Deller <deller@gmx.de>
Fixes: 7c0dfcf9395e ("target/hppa: Update SeaBIOS-hppa to version 16")
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 2536c15adcf6232e5f649405db76876620610652
      
https://github.com/qemu/qemu/commit/2536c15adcf6232e5f649405db76876620610652
  Author: Helge Deller <deller@gmx.de>
  Date:   2024-03-03 (Sun, 03 Mar 2024)

  Changed paths:
    M pc-bios/README

  Log Message:
  -----------
  pc-bios/README: Add information about hppa-firmware

Signed-off-by: Helge Deller <deller@gmx.de>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 839a88e8bd1a1efe05844c39a59985482894f4de
      
https://github.com/qemu/qemu/commit/839a88e8bd1a1efe05844c39a59985482894f4de
  Author: Helge Deller <deller@gmx.de>
  Date:   2024-03-03 (Sun, 03 Mar 2024)

  Changed paths:
    M roms/Makefile

  Log Message:
  -----------
  roms/hppa: Add build rules for hppa-firmware

Signed-off-by: Helge Deller <deller@gmx.de>
Suggested-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: eb844330bd36ebdd4959053da08069d1e5d49119
      
https://github.com/qemu/qemu/commit/eb844330bd36ebdd4959053da08069d1e5d49119
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2024-03-04 (Mon, 04 Mar 2024)

  Changed paths:
    M docs/conf.py

  Log Message:
  -----------
  docs/conf.py: Remove usage of distutils

The macOS jobs in our CI recently started failing, complaining that
the distutils module is not available anymore. And indeed, according to
https://peps.python.org/pep-0632/ it's been deprecated since a while
and now likely got removed in recent Python versions.

Fortunately, we only use it for a version check via LooseVersion here
which we don't really need anymore - according to Repology.org, these
are the versions of sphinx-rtd-theme that are currently used by the
various distros:

 centos_stream_8: 0.3.1
 centos_stream_9: 0.5.1
 fedora_38: 1.1.1
 fedora_39: 1.2.2
 freebsd: 1.0.0
 haikuports_master: 1.2.1
 openbsd: 1.2.2
 opensuse_leap_15_5: 0.5.1
 pkgsrc_current: 2.0.0
 debian_11: 0.5.1
 debian_12: 1.2.0
 ubuntu_20_04: 0.4.3
 ubuntu_22_04: 1.0.0
 ubuntu_24_04: 2.0.0

So except for CentOS 8, all distros are using a newer version of
sphinx-rtd-theme, and for CentOS 8 we don't support compiling with
the Sphinx of the distro anymore anyway, since it's based on the
Python 3.6 interpreter there. For compiling on CentOS 8, you have
to use the alternative Python 3.8 interpreter which comes without
Sphinx, so that needs the Sphinx installed via pip in the venv
instead, and that is using a newer version, too, according to our
pythondeps.toml file.

Thus we can simply drop the version check now to get rid of the
distutils dependency here.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Message-id: 20240304130403.129543-1-thuth@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 956331108e78cd8cee166a9735fac78c5f36ec55
      
https://github.com/qemu/qemu/commit/956331108e78cd8cee166a9735fac78c5f36ec55
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2024-03-04 (Mon, 04 Mar 2024)

  Changed paths:
    M meson.build

  Log Message:
  -----------
  meson: detect broken clang 17 with -fzero-call-used-regs

Clang 17 will segv if given  -fzero-call-used-regs and optimization
is enabled. Since upstream hasn't triaged the bug, distros are
increasingly shipping with broken Clang.

https://github.com/llvm/llvm-project/issues/75168
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277474
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20240304144456.3825935-2-berrange@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 9ea920dc28254cd9a363aaef01985dffd8abedd7
      
https://github.com/qemu/qemu/commit/9ea920dc28254cd9a363aaef01985dffd8abedd7
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2024-03-04 (Mon, 04 Mar 2024)

  Changed paths:
    M .gitlab-ci.d/cirrus.yml

  Log Message:
  -----------
  gitlab: update FreeBSD Cirrus CI image to 13.3

The 13.2 images have been deleted from gcloud

Cc: qemu-stable@nongnu.org
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20240304144456.3825935-3-berrange@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 52e7db443bd8d233acc3977bd150bdadb62db86c
      
https://github.com/qemu/qemu/commit/52e7db443bd8d233acc3977bd150bdadb62db86c
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-03-04 (Mon, 04 Mar 2024)

  Changed paths:
    M pc-bios/README
    M pc-bios/meson.build
    M roms/Makefile
    M target/hppa/cpu.c
    M target/hppa/helper.c
    M target/hppa/mem_helper.c
    M target/hppa/op_helper.c

  Log Message:
  -----------
  Merge tag 'hppa-latest-pull-request' of https://github.com/hdeller/qemu-hppa 
into staging

HPPA64 updates

# -----BEGIN PGP SIGNATURE-----
#
# iHUEABYKAB0WIQS86RI+GtKfB8BJu973ErUQojoPXwUCZeQOtQAKCRD3ErUQojoP
# Xzh6AP9Gs8sJzRbR+HLlbrs3ACR7kQEVGOYuuBEJpKqkTyDbLwD/YdOjzgtTRKLd
# imxaWOJaLhpvBrmFLxn3Q58K3n9u1wY=
# =bnMy
# -----END PGP SIGNATURE-----
# gpg: Signature made Sun 03 Mar 2024 05:46:29 GMT
# gpg:                using EDDSA key BCE9123E1AD29F07C049BBDEF712B510A23A0F5F
# gpg: Good signature from "Helge Deller <deller@gmx.de>" [unknown]
# gpg:                 aka "Helge Deller <deller@kernel.org>" [unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 4544 8228 2CD9 10DB EF3D  25F8 3E5F 3D04 A7A2 4603
#      Subkey fingerprint: BCE9 123E 1AD2 9F07 C049  BBDE F712 B510 A23A 0F5F

* tag 'hppa-latest-pull-request' of https://github.com/hdeller/qemu-hppa:
  roms/hppa: Add build rules for hppa-firmware
  pc-bios/README: Add information about hppa-firmware
  pc-bios/meson: Add hppa-firmware64.img blob
  target/hppa: Restore unwind_breg before calculating ior
  target: hppa: Fix unaligned double word accesses for hppa64

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/dcce36a7cd45...52e7db443bd8

To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications
reply via email to
[Prev in Thread] Current Thread [Next in Thread]