[Qemu-commits] [qemu/qemu] 2f73ed: hw/ide/ahci: Rename ahci

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 2f73ed: hw/ide/ahci: Rename ahci_internal.h t

From:	Peter Maydell
Subject:	[Qemu-commits] [qemu/qemu] 2f73ed: hw/ide/ahci: Rename ahci_internal.h to ahci-intern...
Date:	Tue, 12 Mar 2024 06:14:07 -0700
  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 2f73edac568fb6a49594a7367c85c0a4425c7ea6
      
https://github.com/qemu/qemu/commit/2f73edac568fb6a49594a7367c85c0a4425c7ea6
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    A hw/ide/ahci-internal.h
    M hw/ide/ahci.c
    R hw/ide/ahci_internal.h
    M hw/ide/ich.c

  Log Message:
  -----------
  hw/ide/ahci: Rename ahci_internal.h to ahci-internal.h

Other headers now use dash instead of underscore. Rename
ahci_internal.h accordingly for consistency.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240227131310.C24EB4E6005@zero.eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: 86f0aa1d438e0db61015678164b835cedc80795c
      
https://github.com/qemu/qemu/commit/86f0aa1d438e0db61015678164b835cedc80795c
  Author: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M hw/pci/pcie.c
    M hw/pci/shpc.c
    M hw/pci/trace-events

  Log Message:
  -----------
  hw/pci: add some convenient trace-events for pcie and shpc hotplug

Add trace-events that may help to debug problems with hotplugging.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240301154146.761531-2-vsementsov@yandex-team.ru>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: d36b2f4e783f984b781f4510f56d571415e1b6cd
      
https://github.com/qemu/qemu/commit/d36b2f4e783f984b781f4510f56d571415e1b6cd
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M hw/ppc/sam460ex.c

  Log Message:
  -----------
  hw/ppc/sam460ex: Support short options for adding drives

Having to use -drive if=none,... and -device ide-[cd,hd] is
inconvenient. Add support for shorter convenience options such as
-cdrom and -drive media=disk. Also adjust two nearby comments for code
style.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-ID: <20240305225721.E9A404E6005@zero.eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: bfd65b4ba5659eda3a47a0099679812d58d14f3b
      
https://github.com/qemu/qemu/commit/bfd65b4ba5659eda3a47a0099679812d58d14f3b
  Author: Zhao Liu <zhao1.liu@intel.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M hw/core/loader-fit.c

  Log Message:
  -----------
  hw/core/loader-fit: Fix missing ERRP_GUARD() for error_prepend()

As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():

* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
*   error_append_hint(), because that doesn't work with &error_fatal.
* ERRP_GUARD() lifts these restrictions.
*
* To use ERRP_GUARD(), add it right at the beginning of the function.
* @errp can then be used without worrying about the argument being
* NULL or &error_fatal.

ERRP_GUARD() could avoid the case when @errp is &error_fatal, the user
can't see this additional information, because exit() happens in
error_setg earlier than information is added [1].

In hw/core/loader-fit.c, there are 2 functions passing @errp to
error_prepend() without ERRP_GUARD():
 - fit_load_kernel()
 - fit_load_fdt()

Their @errp parameters are both the pointers of the local @err virable
in load_fit().

Though they don't cause the issue like [1] said, to follow the
requirement of @errp, add missing ERRP_GUARD() at their beginning.

[1]: Issue description in the commit message of commit ae7c80a7bd73
     ("error: New macro ERRP_GUARD()").

Cc: Paul Burton <paulburton@kernel.org>
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Message-ID: <20240311033822.3142585-15-zhao1.liu@linux.intel.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: 688f2349a7b8d99cc3b53646c072d14cb1444db9
      
https://github.com/qemu/qemu/commit/688f2349a7b8d99cc3b53646c072d14cb1444db9
  Author: Zhao Liu <zhao1.liu@intel.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M hw/core/qdev-properties-system.c

  Log Message:
  -----------
  hw/core/qdev-properties-system: Fix missing ERRP_GUARD() for error_prepend()

As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():

* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
*   error_append_hint(), because that doesn't work with &error_fatal.
* ERRP_GUARD() lifts these restrictions.
*
* To use ERRP_GUARD(), add it right at the beginning of the function.
* @errp can then be used without worrying about the argument being
* NULL or &error_fatal.

ERRP_GUARD() could avoid the case when @errp is &error_fatal, the user
can't see this additional information, because exit() happens in
error_setg earlier than information is added [1].

The set_chr() passes @errp to error_prepend() without ERRP_GUARD().

As a PropertyInfo.set method, there are too many possible callers to
check the impact of this defect; it may or may not be harmless. Thus it
is necessary to protect @errp with ERRP_GUARD().

To avoid the issue like [1] said, add missing ERRP_GUARD() at the
beginning of this function.

[1]: Issue description in the commit message of commit ae7c80a7bd73
     ("error: New macro ERRP_GUARD()").

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com
Cc: Eduardo Habkost <eduardo@habkost.net>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240311033822.3142585-16-zhao1.liu@linux.intel.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: b691b250d3860f007799b1b427689c707b796bba
      
https://github.com/qemu/qemu/commit/b691b250d3860f007799b1b427689c707b796bba
  Author: Zhao Liu <zhao1.liu@intel.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M hw/misc/ivshmem.c

  Log Message:
  -----------
  hw/misc/ivshmem: Fix missing ERRP_GUARD() for error_prepend()

As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():

* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
*   error_append_hint(), because that doesn't work with &error_fatal.
* ERRP_GUARD() lifts these restrictions.
*
* To use ERRP_GUARD(), add it right at the beginning of the function.
* @errp can then be used without worrying about the argument being
* NULL or &error_fatal.

ERRP_GUARD() could avoid the case when @errp is &error_fatal, the user
can't see this additional information, because exit() happens in
error_setg earlier than information is added [1].

The ivshmem_common_realize() passes @errp to error_prepend(), and as a
DeviceClass.realize method, there are too many possible callers to check
the impact of this defect; it may or may not be harmless. Thus it is
necessary to protect @errp with ERRP_GUARD().

To avoid the issue like [1] said, add missing ERRP_GUARD() at the
beginning of this function.

[1]: Issue description in the commit message of commit ae7c80a7bd73
     ("error: New macro ERRP_GUARD()").

Cc: Juan Quintela <quintela@trasno.org>
Cc: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Cc: Michael Galaxy <mgalaxy@akamai.com>
Cc: Steve Sistare <steven.sistare@oracle.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Message-ID: <20240311033822.3142585-17-zhao1.liu@linux.intel.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: c1c73b31d941220392ead0ea5ab6966943cb1b55
      
https://github.com/qemu/qemu/commit/c1c73b31d941220392ead0ea5ab6966943cb1b55
  Author: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M hw/sparc64/sun4u.c

  Log Message:
  -----------
  sun4u: remap ebus BAR0 to use unassigned_io_ops instead of alias to PCI IO 
space

During kernel startup OpenBSD accesses addresses mapped by BAR0 of the ebus 
device
but at offsets where no IO devices exist. Before commit 4aa07e8649 
("hw/sparc64/ebus:
Access memory regions via pci_address_space_io()") BAR0 was mapped to legacy IO
space which allows accesses to unmapped devices to succeed, but afterwards these
accesses to unmapped PCI IO space cause a memory fault which prevents OpenBSD 
from
booting.

Since no devices are mapped at the addresses accessed by OpenBSD, change ebus 
BAR0
from a PCI IO space alias to an IO memory region using unassigned_io_ops which 
allows
these accesses to succeed and so allows OpenBSD to boot once again.

Fixes: 4aa07e8649 ("hw/sparc64/ebus: Access memory regions via 
pci_address_space_io()")
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240311064345.2531197-1-mark.cave-ayland@ilande.co.uk>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: 2ed22b2c6a44ddf11efe98813ccfcf0c24a2946b
      
https://github.com/qemu/qemu/commit/2ed22b2c6a44ddf11efe98813ccfcf0c24a2946b
  Author: Zhao Liu <zhao1.liu@intel.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M hw/core/cpu-common.c

  Log Message:
  -----------
  hw/core: Cleanup unused included headers in cpu-common.c

Remove unused headers in cpu-common.c:
* qemu/notify.h
* exec/cpu-common.h
* qemu/error-report.h
* qemu/qemu-print.h

Tested by "./configure" and then "make".

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240311075621.3224684-2-zhao1.liu@linux.intel.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: 5585b0267f301b1b8ee922d41f89d6d2b42e7f90
      
https://github.com/qemu/qemu/commit/5585b0267f301b1b8ee922d41f89d6d2b42e7f90
  Author: Zhao Liu <zhao1.liu@intel.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M hw/core/machine-qmp-cmds.c

  Log Message:
  -----------
  hw/core: Cleanup unused included header in machine-qmp-cmds.c

Remove unused header (qemu/main-loop.h) in machine-qmp-cmds.c.

Tested by "./configure" and then "make".

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240311075621.3224684-3-zhao1.liu@linux.intel.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: 2ea09fe85a1a7006133fa8ee1f467a5758e8f8fb
      
https://github.com/qemu/qemu/commit/2ea09fe85a1a7006133fa8ee1f467a5758e8f8fb
  Author: Zhao Liu <zhao1.liu@intel.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M hw/core/numa.c

  Log Message:
  -----------
  hw/core: Cleanup unused included headers in numa.c

Remove unused header in numa.c:
* qemu/bitmap.h
* migration/vmstate.h

Note: Though parse_numa_hmat_lb() has the variable named "bitmap_copy",
it doesn't use the normal bitmap ops so that it's safe to exclude
qemu/bitmap.h header.

Tested by "./configure" and then "make".

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240311075621.3224684-4-zhao1.liu@linux.intel.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: 4cbb1513a2d322f858ccb2556715558482fd4850
      
https://github.com/qemu/qemu/commit/4cbb1513a2d322f858ccb2556715558482fd4850
  Author: Dmitriy Sharikhin <d.sharikhin@yadro.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M MAINTAINERS
    M hw/gpio/Kconfig
    M hw/gpio/meson.build
    A hw/gpio/pcf8574.c
    A include/hw/gpio/pcf8574.h

  Log Message:
  -----------
  hw/gpio: introduce pcf8574 driver

NXP PCF8574 and compatible ICs are simple I2C GPIO expanders.
PCF8574 incorporates quasi-bidirectional IO, and simple
communication protocol, when IO read is I2C byte read, and
IO write is I2C byte write. User can think of it as
open-drain port, when line high state is input and line low
state is output.

Signed-off-by: Dmitrii Sharikhin <d.sharikhin@yadro.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <f1552d822276e878d84c01eba2cf2c7c9ebdde00.camel@yadro.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: 2ef938a0994097969aab947aeb49982572640687
      
https://github.com/qemu/qemu/commit/2ef938a0994097969aab947aeb49982572640687
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M meson.build

  Log Message:
  -----------
  meson.build: Always require an objc compiler on macos hosts

We currently only insist that an ObjectiveC compiler is present on
macos hosts if we're building the Cocoa UI.  However, since then
we've added some other parts of QEMU which are also written in ObjC:
the coreaudio audio backend, and the vmnet net backend.  This means
that if you try to configure QEMU on macos with --disable-cocoa the
build will fail:

../meson.build:3741:13: ERROR: No host machine compiler for 'audio/coreaudio.m'

Since in practice any macos host will have an ObjC compiler
available, rather than trying to gate the compiler detection on an
increasingly complicated list of every bit of QEMU that uses ObjC,
just require it unconditionally on macos hosts.

Resolves https://gitlab.com/qemu-project/qemu/-/issues/2138

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20240311133334.3991537-1-peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: afc8b05cea14b2eea6f1eaa640f74b21486fca48
      
https://github.com/qemu/qemu/commit/afc8b05cea14b2eea6f1eaa640f74b21486fca48
  Author: Zhao Liu <zhao1.liu@intel.com>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M docs/about/deprecated.rst

  Log Message:
  -----------
  docs/about/deprecated.rst: Move SMP configurations item to system emulator 
section

In the commit 54c4ea8f3ae6 ("hw/core/machine-smp: Deprecate unsupported
'parameter=1' SMP configurations"), the SMP related item is put under
the section "User-mode emulator command line arguments" instead of
"System emulator command line arguments".

-smp is a system emulator command, so move SMP configurations item to
system emulator section.

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20240312071512.3283513-1-zhao1.liu@linux.intel.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: 29e238cfb041190abd6a5984c34decdd77d4680b
      
https://github.com/qemu/qemu/commit/29e238cfb041190abd6a5984c34decdd77d4680b
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M .gitlab-ci.d/base.yml
    M .gitlab-ci.d/buildtest-template.yml
    M .gitlab-ci.d/buildtest.yml
    M .gitlab-ci.d/windows.yml

  Log Message:
  -----------
  gitlab: aggressively avoid extra GIT data

This avoids fetching blobs and tree references for branches we are not
going to worry about. Also skip tag references which are similarly not
useful and keep the default --prune. This keeps the .git data to
around 100M rather than the ~400M even a shallow clone takes.

So we can check the savings we also run a quick du while setting up
the build.

We also have to have special settings of GIT_FETCH_EXTRA_FLAGS for the
Windows build (git too old?) and the migration legacy test where we
build an older QEMU alongside the main one.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


  Commit: c2ace3f18c2d978cd4ee79e3dd050337b1d479df
      
https://github.com/qemu/qemu/commit/c2ace3f18c2d978cd4ee79e3dd050337b1d479df
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M tests/vm/basevm.py

  Log Message:
  -----------
  tests/vm: ensure we build everything by default

The "check" target by itself is not enough to ensure we build the user
mode binaries. While we can't test them with check-tcg we can at least
include them in the build.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Cc: Richard Henderson <richard.henderson@linaro.org>
Cc: Gustavo Romero <gustavo.romero@linaro.org>


  Commit: 7d4836195920d3cbcd45c6d90237dfe02fafa0bc
      
https://github.com/qemu/qemu/commit/7d4836195920d3cbcd45c6d90237dfe02fafa0bc
  Author: Gustavo Romero <gustavo.romero@linaro.org>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M gdbstub/user.c
    M include/gdbstub/user.h
    M linux-user/main.c
    M linux-user/signal.c

  Log Message:
  -----------
  gdbstub: Rename back gdb_handlesig

Rename gdb_handlesig_reason back to gdb_handlesig. There is no need to
add a wrapper for gdb_handlesig and rename it when a new parameter is
added.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240309030901.1726211-2-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


  Commit: 7ee9e7ec00b04ec716c750f7ea61080acbc4d3d0
      
https://github.com/qemu/qemu/commit/7ee9e7ec00b04ec716c750f7ea61080acbc4d3d0
  Author: Gustavo Romero <gustavo.romero@linaro.org>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M linux-user/aarch64/signal.c
    M linux-user/alpha/signal.c
    M linux-user/arm/signal.c
    M linux-user/hexagon/signal.c
    M linux-user/hppa/signal.c
    M linux-user/i386/signal.c
    M linux-user/loongarch64/signal.c
    M linux-user/m68k/signal.c
    M linux-user/microblaze/signal.c
    M linux-user/mips/signal.c
    M linux-user/nios2/signal.c
    M linux-user/openrisc/signal.c
    M linux-user/ppc/signal.c
    M linux-user/riscv/signal.c
    M linux-user/s390x/signal.c
    M linux-user/sh4/signal.c
    M linux-user/signal-common.h
    M linux-user/signal.c
    M linux-user/sparc/signal.c
    M linux-user/xtensa/signal.c

  Log Message:
  -----------
  linux-user: Move tswap_siginfo out of target code

Move tswap_siginfo from target code to handle_pending_signal. This will
allow some cleanups and having the siginfo ready to be used in gdbstub.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240309030901.1726211-3-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


  Commit: 3e8de395fb7a4691218c3213ece20ee986488130
      
https://github.com/qemu/qemu/commit/3e8de395fb7a4691218c3213ece20ee986488130
  Author: Gustavo Romero <gustavo.romero@linaro.org>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M bsd-user/main.c
    M bsd-user/signal.c
    M gdbstub/user.c
    M include/gdbstub/user.h
    M linux-user/main.c
    M linux-user/signal.c

  Log Message:
  -----------
  gdbstub: Save target's siginfo

Save target's siginfo into gdbserver_state so it can be used later, for
example, in any stub that requires the target's si_signo and si_code.

This change affects only linux-user mode.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240309030901.1726211-4-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: ae73fa10da04a527e6bbb75a739107b3e3a12428
      
https://github.com/qemu/qemu/commit/ae73fa10da04a527e6bbb75a739107b3e3a12428
  Author: Gustavo Romero <gustavo.romero@linaro.org>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M gdbstub/gdbstub.c
    M gdbstub/internals.h
    M gdbstub/user.c

  Log Message:
  -----------
  gdbstub: Add Xfer:siginfo:read stub

Add stub to handle Xfer:siginfo:read packet query that requests the
machine's siginfo data.

This is used when GDB user executes 'print $_siginfo' and when the
machine stops due to a signal, for instance, on SIGSEGV. The information
in siginfo allows GDB to determiner further details on the signal, like
the fault address/insn when the SIGSEGV is caught.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Message-Id: <20240309030901.1726211-5-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 0d57c040b40dbcb2960c47e9e70fee00e3ebaef3
      
https://github.com/qemu/qemu/commit/0d57c040b40dbcb2960c47e9e70fee00e3ebaef3
  Author: Gustavo Romero <gustavo.romero@linaro.org>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M tests/tcg/multiarch/Makefile.target
    A tests/tcg/multiarch/gdbstub/test-qxfer-siginfo-read.py
    A tests/tcg/multiarch/segfault.c

  Log Message:
  -----------
  tests/tcg: Add multiarch test for Xfer:siginfo:read stub

Add multiarch test for testing if Xfer:siginfo:read query is properly
handled by gdbstub.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240309030901.1726211-6-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


  Commit: 0532045e8112c13a8a949e696576672e64c6fa14
      
https://github.com/qemu/qemu/commit/0532045e8112c13a8a949e696576672e64c6fa14
  Author: Ilya Leoshkevich <iii@linux.ibm.com>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M gdbstub/user.c

  Log Message:
  -----------
  gdbstub: Fix double close() of the follow-fork-mode socket

When the terminal GDB_FORK_ENABLED state is reached, the coordination
socket is not needed anymore and is therefore closed. However, if there
is a communication error between QEMU gdbstub and GDB, the generic
error handling code attempts to close it again.

Fix by closing it later - before returning - instead.

Fixes: Coverity CID 1539966
Fixes: d547e711a8a5 ("gdbstub: Implement follow-fork-mode child")
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240312001813.13720-1-iii@linux.ibm.com>


  Commit: 8e1c26cdfbe366a961c69d154adfc4a4be922393
      
https://github.com/qemu/qemu/commit/8e1c26cdfbe366a961c69d154adfc4a4be922393
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M MAINTAINERS
    M docs/about/deprecated.rst
    M hw/core/cpu-common.c
    M hw/core/loader-fit.c
    M hw/core/machine-qmp-cmds.c
    M hw/core/numa.c
    M hw/core/qdev-properties-system.c
    M hw/gpio/Kconfig
    M hw/gpio/meson.build
    A hw/gpio/pcf8574.c
    A hw/ide/ahci-internal.h
    M hw/ide/ahci.c
    R hw/ide/ahci_internal.h
    M hw/ide/ich.c
    M hw/misc/ivshmem.c
    M hw/pci/pcie.c
    M hw/pci/shpc.c
    M hw/pci/trace-events
    M hw/ppc/sam460ex.c
    M hw/sparc64/sun4u.c
    A include/hw/gpio/pcf8574.h
    M meson.build

  Log Message:
  -----------
  Merge tag 'hw-misc-20240312' of https://github.com/philmd/qemu into staging

Misc HW patch queue

- Rename hw/ide/ahci-internal.h for consistency (Zoltan)
- More convenient PCI hotplug trace events (Vladimir)
- Short CLI option to add drives for sam460ex machine (Zoltan)
- More missing ERRP_GUARD() macros (Zhao)
- Avoid faulting when unmapped I/O BAR is accessed on SPARC EBUS (Mark)
- Remove unused includes in hw/core/ (Zhao)
- New PCF8574 GPIO over I2C model (Dmitriy)
- Require ObjC on Darwin macOS by default (Peter)
- Corrected "-smp parameter=1" placement in docs/ (Zhao)

# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEE+qvnXhKRciHc/Wuy4+MsLN6twN4FAmXwEJkACgkQ4+MsLN6t
# wN4A3hAAngVu7VmyrfqYF6jfDMUuRGYaKf4D73/KF6R1PsU+nJdN7UAkECLj8o7g
# mkcAQu1U3fKCUssF6MJ2a3kU+rD1OkkA/ZcitzgWwEjCK8KVjtMt2HzEqX+B/X+e
# RUVjXMOMkyV48MF0+yLhJz+lQiDpEBFVxIgssPBNUz1Pw9IfoXp29Bfz+bYBThS4
# ywAdvCefNzSira0Nt6RWTnvgBHB/1+aLy1uMSt0Xu926zcqoxQJ0b//0flYL8vAf
# JuSSZuiXPw+oAc3qG3d6aPl3g8DrFn3pvPD471KlFQAnB0dlhEZZqNBPvraySpHl
# h04Y8teHYj9XfxPtaWfaEdgQCazdkKFR/q7E5c9GU00Rf469BJeuo9Pzkm4kWfbU
# sbCl8em5biVZ5DpBIOMT3/D0JOyGf7/CM8y5c3Jc92hapx2NdSszkvCicrDE1+i0
# zEr4N0P/F2x5KFVFkQ3Xzv2Jtzw+iXj6kSE5a5/64GMK29Mqu/EPaSkvwGDQOs3N
# QJ9mpa4gg47g310a0/nH0i5eVbvGVuzcCMP6VXOBVr18cJ7JFQFFiYcvoTDXNQ2m
# sq5xUelRimnWfKpawomJXkS+/j0usH61/aQBuDKfj45i8/XFRejCIk0gMWQ9hjyD
# no1HqDN8CVXtiPNSinC7ctNHU5ClS0xO/BRl0h3PGC7Bl+A2eVY=
# =JQg1
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 12 Mar 2024 08:21:45 GMT
# gpg:                using RSA key FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE
# gpg: Good signature from "Philippe Mathieu-Daudé (F4BUG) <f4bug@amsat.org>" 
[full]
# Primary key fingerprint: FAAB E75E 1291 7221 DCFD  6BB2 E3E3 2C2C DEAD C0DE

* tag 'hw-misc-20240312' of https://github.com/philmd/qemu:
  docs/about/deprecated.rst: Move SMP configurations item to system emulator 
section
  meson.build: Always require an objc compiler on macos hosts
  hw/gpio: introduce pcf8574 driver
  hw/core: Cleanup unused included headers in numa.c
  hw/core: Cleanup unused included header in machine-qmp-cmds.c
  hw/core: Cleanup unused included headers in cpu-common.c
  sun4u: remap ebus BAR0 to use unassigned_io_ops instead of alias to PCI IO 
space
  hw/misc/ivshmem: Fix missing ERRP_GUARD() for error_prepend()
  hw/core/qdev-properties-system: Fix missing ERRP_GUARD() for error_prepend()
  hw/core/loader-fit: Fix missing ERRP_GUARD() for error_prepend()
  hw/ppc/sam460ex: Support short options for adding drives
  hw/pci: add some convenient trace-events for pcie and shpc hotplug
  hw/ide/ahci: Rename ahci_internal.h to ahci-internal.h

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 4f0d7dba5536bfe861a3b2035162689badd00501
      
https://github.com/qemu/qemu/commit/4f0d7dba5536bfe861a3b2035162689badd00501
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M .gitlab-ci.d/base.yml
    M .gitlab-ci.d/buildtest-template.yml
    M .gitlab-ci.d/buildtest.yml
    M .gitlab-ci.d/windows.yml
    M bsd-user/main.c
    M bsd-user/signal.c
    M gdbstub/gdbstub.c
    M gdbstub/internals.h
    M gdbstub/user.c
    M include/gdbstub/user.h
    M linux-user/aarch64/signal.c
    M linux-user/alpha/signal.c
    M linux-user/arm/signal.c
    M linux-user/hexagon/signal.c
    M linux-user/hppa/signal.c
    M linux-user/i386/signal.c
    M linux-user/loongarch64/signal.c
    M linux-user/m68k/signal.c
    M linux-user/main.c
    M linux-user/microblaze/signal.c
    M linux-user/mips/signal.c
    M linux-user/nios2/signal.c
    M linux-user/openrisc/signal.c
    M linux-user/ppc/signal.c
    M linux-user/riscv/signal.c
    M linux-user/s390x/signal.c
    M linux-user/sh4/signal.c
    M linux-user/signal-common.h
    M linux-user/signal.c
    M linux-user/sparc/signal.c
    M linux-user/xtensa/signal.c
    M tests/tcg/multiarch/Makefile.target
    A tests/tcg/multiarch/gdbstub/test-qxfer-siginfo-read.py
    A tests/tcg/multiarch/segfault.c
    M tests/vm/basevm.py

  Log Message:
  -----------
  Merge tag 'pull-maintainer-final-120324-1' of https://gitlab.com/stsquad/qemu 
into staging

final updates for 9.0 (testing, gdbstub):

  - avoid transferring pointless git data
  - fix the over rebuilding of test VMs
  - support Xfer:siginfo:read in gdbstub
  - fix double close() in gdbstub

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCgAdFiEEZoWumedRZ7yvyN81+9DbCVqeKkQFAmXwNgsACgkQ+9DbCVqe
# KkTETwf+P0wiT8+ww43+sJxZSDw9NsjZ4LYAjp27jeyaNhKV5uCeAGNIKllX8+u/
# zrR0VkNsFG9AKU/G0Se71tX+hKeg+1BPLKERm9T7OaAQiP2OkYCGy2FUYgiAasQP
# Re7cRbLwpMYbwu007q6uGU1TU/WCvmlwfCoJYFC2hqzeNg6tu78hzqOP0ydL+6t1
# tNXjls9vesnz+/vrj6bXjrxNf5uex6L2AaUsJS9u9ipvY6JOgXSublyZ1ex1sIOO
# DBIqhlXosa1ScXHKnoklH1tKmF59L3aDZNCca+IGzXFmAkd0jlFD5C4ro87ar5QB
# 3NcMzLKBheraYgLpOClm8SZ+38N4Fw==
# =nJAF
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 12 Mar 2024 11:01:31 GMT
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) 
<alex.bennee@linaro.org>" [full]
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* tag 'pull-maintainer-final-120324-1' of https://gitlab.com/stsquad/qemu:
  gdbstub: Fix double close() of the follow-fork-mode socket
  tests/tcg: Add multiarch test for Xfer:siginfo:read stub
  gdbstub: Add Xfer:siginfo:read stub
  gdbstub: Save target's siginfo
  linux-user: Move tswap_siginfo out of target code
  gdbstub: Rename back gdb_handlesig
  tests/vm: ensure we build everything by default
  gitlab: aggressively avoid extra GIT data

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/8f3f329f5e01...4f0d7dba5536

To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] 2f73ed: hw/ide/ahci: Rename ahci_internal.h to ahci-intern..., Peter Maydell <=
- [Qemu-commits] [qemu/qemu] 2f73ed: hw/ide/ahci: Rename ahci_internal.h to ahci-intern..., Peter Maydell, 2024/03/12
Prev by Date: [Qemu-commits] [qemu/qemu] a2531b: hw/arm: Deprecate various old Arm machine types
Next by Date: [Qemu-commits] [qemu/qemu] 65c2ab: igb: fix link state on resume
Previous by thread: [Qemu-commits] [qemu/qemu] 4e1871: migration: Don't serialize devices in qemu_savevm_...
Next by thread: [Qemu-commits] [qemu/qemu] 2f73ed: hw/ide/ahci: Rename ahci_internal.h to ahci-intern...
Index(es):
- Date
- Thread