[Qemu-devel] Re: [PATCH 1/7] clean build: Add bt_host_hci prototype

[Aurelien Jarno]

On Sun, Mar 08, 2009 at 03:56:12PM +0100, Jan Kiszka wrote:
> Jan Kiszka wrote:
> > Silence compiler warning by providing a prototype in the CONFIG_BLUEZ
> > case (hw/bt.h provides it otherwise).
> > 
> > Signed-off-by: Jan Kiszka <address@hidden>
> > ---
> > 
> >  bt-host.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/bt-host.c b/bt-host.c
> > index 07679f6..066757a 100644
> > --- a/bt-host.c
> > +++ b/bt-host.c
> > @@ -31,6 +31,8 @@
> >  #  include <bluetooth/bluetooth.h>
> >  #  include <bluetooth/hci.h>
> >  #  include <bluetooth/hci_lib.h>
> > +/* Silence compiler warning */
> > +struct HCIInfo *bt_host_hci(const char *id);
> >  # else
> >  #  include "hw/bt.h"
> >  #  define HCI_MAX_FRAME_SIZE       1028
> 
> Thanks for applying the other patches, but this tiny one always seems to
> be ignored - for unknown reasons. :)
> 

On my side, I consider that a hack, not a fix. We should make sure the
correct header is included so that this function is declared.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net