[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 5/5] replay: introduce block devices record/r
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 5/5] replay: introduce block devices record/replay |
|
Date: |
Fri, 11 Mar 2016 13:59:59 +0000 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Mar 10, 2016 at 02:56:20PM +0300, Pavel Dovgalyuk wrote:
> +static void block_request_create(uint64_t reqid, BlockDriverState *bs,
> + Coroutine *co)
> +{
> + Request *req = g_new(Request, 1);
> + *req = (Request) {
> + .co = co,
> + .bh = aio_bh_new(bdrv_get_aio_context(bs), blkreplay_bh_cb, req),
> + };
> + replay_block_event(req->bh, reqid);
Regarding thread safety: is replay_block_event() thread-safe?
If QEMU runs with IOThreads then this might not be called under the QEMU
global mutex.
Stefan
signature.asc
Description: PGP signature