[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] qom: cpu: destroy work_mutex in cpu_common_finalize
From: |
Li Qiang |
Subject: |
[Qemu-devel] [PATCH] qom: cpu: destroy work_mutex in cpu_common_finalize |
Date: |
Tue, 1 Jan 2019 23:41:14 -0800 |
Commit 376692b9dc6(cpus: protect work list with work_mutex)
initialize a work_mutex in cpu_common_initfn, however forget
to destroy it. This will cause resource leak when hotunplug cpu
or hotplug cpu fails.
Signed-off-by: Li Qiang <address@hidden>
---
qom/cpu.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/qom/cpu.c b/qom/cpu.c
index 9ad1372d57..367ebf9d61 100644
--- a/qom/cpu.c
+++ b/qom/cpu.c
@@ -380,6 +380,9 @@ static void cpu_common_initfn(Object *obj)
static void cpu_common_finalize(Object *obj)
{
+ CPUState *cpu = CPU(obj);
+
+ qemu_mutex_destroy(&cpu->work_mutex);
}
static int64_t cpu_common_get_arch_id(CPUState *cpu)
--
2.17.1
- [Qemu-devel] [PATCH] qom: cpu: destroy work_mutex in cpu_common_finalize,
Li Qiang <=