[Qemu-devel] 答复: [PATCH] usb: dev-mtp: fix memory leak in error path

[Li Qiang]

Oh, sorry, I always forget to add this “Fixs: xxx” for these small issues.

Thanks,
Li Qiang


发件人: Philippe Mathieu-Daudé
发送时间: 2019年1月3日 21:38
收件人: Li Qiang; address@hidden
抄送: address@hidden; address@hidden
主题: Re: [Qemu-devel] [PATCH] usb: dev-mtp: fix memory leak in error path

On 1/3/19 2:26 PM, Li Qiang wrote:
> Spotted by Coverity: CID 1397074
> 

Gerd, if you take this, can you add:

Fixes: c52d46e041b
> Signed-off-by: Li Qiang <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  hw/usb/dev-mtp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
> index 6098005cd4..b19b576278 100644
> --- a/hw/usb/dev-mtp.c
> +++ b/hw/usb/dev-mtp.c
> @@ -1729,6 +1729,7 @@ static void usb_mtp_write_metadata(MTPState *s, 
> uint64_t dlen)
>      if (strchr(filename, '/')) {
>          usb_mtp_queue_result(s, RES_PARAMETER_NOT_SUPPORTED, d->trans,
>                               0, 0, 0, 0);
> +        g_free(filename);
>          return;
>      }
>  
>