Re: [Qemu-devel] [PATCH 1/2] scripts/update-linux-headers.sh: adjust for Linux 4.21-rc1 (or 5.0-rc1)

[Peter Maydell]

On Fri, 4 Jan 2019 at 11:02, Paolo Bonzini <address@hidden> wrote:
>
> On 04/01/19 10:26, Cornelia Huck wrote:
> > On Fri,  4 Jan 2019 09:27:30 +0100
> > Paolo Bonzini <address@hidden> wrote:
> >
> >> There are three new indirect inclusions: vhost_types.h, which we'll
> >> shortly put to use as a portable header and thus is copied to
> >> standard-headers; and new per-subtarget versions of MIPS unistd.h
> >> and PowerPC unistd.h.
> >>
> >> Because vhost.h includes vhost_types.h, we also need a proxy include
> >> from linux/vhost.h to standard-headers.
> >>
> >> Signed-off-by: Paolo Bonzini <address@hidden>
> >> ---
> >>  scripts/update-linux-headers.sh | 11 +++++++++++
> >>  1 file changed, 11 insertions(+)
> >
> > I still think we could squash this change (and the description :) with
> > the headers update, but I don't object to a separate change, either.
>
> Me too, but I figured I'd rather not pull another tantrum like I did for
> multiline comments...

I do find it more easily reviewable this way, so thanks for doing
the split. Admittedly this is partly because my mail client's UI is
not very good for long messages, so this biases me towards
preferring shorter patches rather than ones which are longer
but where only a subsection of them requires close review.

I notice that we now have 3 uses of
+cat <<EOF >$output/linux-headers/linux/foo.h
+#include "standard-headers/linux/foo.h"
+EOF

(for virtio_config.h, virtio_ring.h and vhost_types.h);
next time we add one we could probably switch to a for loop,
but it doesn't make enough benefit to justify respinning
this patch.

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM